Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ResourceTest.cpp

Issue 2399473002: Remove Resource::create() to ensure proper subclasses of Resource are created (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/fetch/Resource.h" 5 #include "core/fetch/Resource.h"
6 6
7 #include "core/fetch/MemoryCache.h" 7 #include "core/fetch/MemoryCache.h"
8 #include "core/fetch/RawResource.h"
8 #include "platform/SharedBuffer.h" 9 #include "platform/SharedBuffer.h"
9 #include "platform/network/ResourceRequest.h" 10 #include "platform/network/ResourceRequest.h"
10 #include "platform/network/ResourceResponse.h" 11 #include "platform/network/ResourceResponse.h"
11 #include "platform/testing/TestingPlatformSupport.h" 12 #include "platform/testing/TestingPlatformSupport.h"
12 #include "platform/testing/URLTestHelpers.h" 13 #include "platform/testing/URLTestHelpers.h"
13 #include "public/platform/Platform.h" 14 #include "public/platform/Platform.h"
14 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
15 #include "wtf/Vector.h" 16 #include "wtf/Vector.h"
16 17
17 namespace blink { 18 namespace blink {
(...skipping 19 matching lines...) Expand all
37 ResourceResponse createTestResourceResponse() { 38 ResourceResponse createTestResourceResponse() {
38 ResourceResponse response; 39 ResourceResponse response;
39 response.setURL(URLTestHelpers::toKURL("https://example.com/")); 40 response.setURL(URLTestHelpers::toKURL("https://example.com/"));
40 response.setHTTPStatusCode(200); 41 response.setHTTPStatusCode(200);
41 return response; 42 return response;
42 } 43 }
43 44
44 void createTestResourceAndSetCachedMetadata(const ResourceResponse& response) { 45 void createTestResourceAndSetCachedMetadata(const ResourceResponse& response) {
45 const char testData[] = "test data"; 46 const char testData[] = "test data";
46 Resource* resource = 47 Resource* resource =
47 Resource::create(ResourceRequest(response.url()), Resource::Raw); 48 RawResource::create(ResourceRequest(response.url()), Resource::Raw);
48 resource->setResponse(response); 49 resource->setResponse(response);
49 resource->cacheHandler()->setCachedMetadata( 50 resource->cacheHandler()->setCachedMetadata(
50 100, testData, sizeof(testData), CachedMetadataHandler::SendToPlatform); 51 100, testData, sizeof(testData), CachedMetadataHandler::SendToPlatform);
51 return; 52 return;
52 } 53 }
53 54
54 } // anonymous namespace 55 } // anonymous namespace
55 56
56 TEST(ResourceTest, SetCachedMetadata_SendsMetadataToPlatform) { 57 TEST(ResourceTest, SetCachedMetadata_SendsMetadataToPlatform) {
57 MockPlatform mock; 58 MockPlatform mock;
(...skipping 10 matching lines...) Expand all
68 response.setWasFetchedViaServiceWorker(true); 69 response.setWasFetchedViaServiceWorker(true);
69 createTestResourceAndSetCachedMetadata(response); 70 createTestResourceAndSetCachedMetadata(response);
70 EXPECT_EQ(0u, mock.cachedURLs().size()); 71 EXPECT_EQ(0u, mock.cachedURLs().size());
71 } 72 }
72 73
73 TEST(ResourceTest, RevalidateWithFragment) { 74 TEST(ResourceTest, RevalidateWithFragment) {
74 KURL url(ParsedURLString, "http://127.0.0.1:8000/foo.html"); 75 KURL url(ParsedURLString, "http://127.0.0.1:8000/foo.html");
75 ResourceResponse response; 76 ResourceResponse response;
76 response.setURL(url); 77 response.setURL(url);
77 response.setHTTPStatusCode(200); 78 response.setHTTPStatusCode(200);
78 Resource* resource = Resource::create(url, Resource::Raw); 79 Resource* resource = RawResource::create(url, Resource::Raw);
79 resource->responseReceived(response, nullptr); 80 resource->responseReceived(response, nullptr);
80 resource->finish(); 81 resource->finish();
81 82
82 // Revalidating with a url that differs by only the fragment 83 // Revalidating with a url that differs by only the fragment
83 // shouldn't trigger a securiy check. 84 // shouldn't trigger a securiy check.
84 url.setFragmentIdentifier("bar"); 85 url.setFragmentIdentifier("bar");
85 resource->setRevalidatingRequest(ResourceRequest(url)); 86 resource->setRevalidatingRequest(ResourceRequest(url));
86 ResourceResponse revalidatingResponse; 87 ResourceResponse revalidatingResponse;
87 revalidatingResponse.setURL(url); 88 revalidatingResponse.setURL(url);
88 revalidatingResponse.setHTTPStatusCode(304); 89 revalidatingResponse.setHTTPStatusCode(304);
89 resource->responseReceived(revalidatingResponse, nullptr); 90 resource->responseReceived(revalidatingResponse, nullptr);
90 } 91 }
91 92
92 } // namespace blink 93 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698