Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp

Issue 2399473002: Remove Resource::create() to ensure proper subclasses of Resource are created (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/SubresourceIntegrity.h" 5 #include "core/frame/SubresourceIntegrity.h"
6 6
7 #include "core/HTMLNames.h" 7 #include "core/HTMLNames.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/fetch/IntegrityMetadata.h" 9 #include "core/fetch/IntegrityMetadata.h"
10 #include "core/fetch/RawResource.h"
10 #include "core/fetch/Resource.h" 11 #include "core/fetch/Resource.h"
11 #include "core/html/HTMLScriptElement.h" 12 #include "core/html/HTMLScriptElement.h"
12 #include "platform/Crypto.h" 13 #include "platform/Crypto.h"
13 #include "platform/weborigin/KURL.h" 14 #include "platform/weborigin/KURL.h"
14 #include "platform/weborigin/SecurityOrigin.h" 15 #include "platform/weborigin/SecurityOrigin.h"
15 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
16 #include "wtf/RefPtr.h" 17 #include "wtf/RefPtr.h"
17 #include "wtf/Vector.h" 18 #include "wtf/Vector.h"
18 #include "wtf/dtoa/utils.h" 19 #include "wtf/dtoa/utils.h"
19 #include "wtf/text/WTFString.h" 20 #include "wtf/text/WTFString.h"
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 ResourceResponse response; 199 ResourceResponse response;
199 response.setURL(url); 200 response.setURL(url);
200 response.setHTTPStatusCode(200); 201 response.setHTTPStatusCode(200);
201 if (corsStatus == WithCors) { 202 if (corsStatus == WithCors) {
202 response.setHTTPHeaderField( 203 response.setHTTPHeaderField(
203 "access-control-allow-origin", 204 "access-control-allow-origin",
204 SecurityOrigin::create(allowOriginUrl)->toAtomicString()); 205 SecurityOrigin::create(allowOriginUrl)->toAtomicString());
205 response.setHTTPHeaderField("access-control-allow-credentials", "true"); 206 response.setHTTPHeaderField("access-control-allow-credentials", "true");
206 } 207 }
207 Resource* resource = 208 Resource* resource =
208 Resource::create(ResourceRequest(response.url()), Resource::Raw); 209 RawResource::create(ResourceRequest(response.url()), Resource::Raw);
209 resource->setResponse(response); 210 resource->setResponse(response);
210 return resource; 211 return resource;
211 } 212 }
212 213
213 KURL secureURL; 214 KURL secureURL;
214 KURL insecureURL; 215 KURL insecureURL;
215 RefPtr<SecurityOrigin> secureOrigin; 216 RefPtr<SecurityOrigin> secureOrigin;
216 RefPtr<SecurityOrigin> insecureOrigin; 217 RefPtr<SecurityOrigin> insecureOrigin;
217 218
218 Persistent<Document> document; 219 Persistent<Document> document;
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 expectIntegrity(kBadSha256AndGoodSha384Integrities, kBasicScript, 526 expectIntegrity(kBadSha256AndGoodSha384Integrities, kBasicScript,
526 strlen(kBasicScript), secureURL, insecureURL); 527 strlen(kBasicScript), secureURL, insecureURL);
527 528
528 expectIntegrityFailure(kSha256Integrity, kBasicScript, strlen(kBasicScript), 529 expectIntegrityFailure(kSha256Integrity, kBasicScript, strlen(kBasicScript),
529 secureURL, insecureURL, NoCors); 530 secureURL, insecureURL, NoCors);
530 expectIntegrityFailure(kGoodSha256AndBadSha384Integrities, kBasicScript, 531 expectIntegrityFailure(kGoodSha256AndBadSha384Integrities, kBasicScript,
531 strlen(kBasicScript), secureURL, insecureURL); 532 strlen(kBasicScript), secureURL, insecureURL);
532 } 533 }
533 534
534 } // namespace blink 535 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceTest.cpp ('k') | third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698