Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2393763002: [DevTools] Cleanup DOMExtension.js. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Cleanup DOMExtension.js. BUG=none Committed: https://crrev.com/020999d2033e17c3a14f779a0ae845530a71898f Cr-Commit-Position: refs/heads/master@{#424080}

Patch Set 1 #

Patch Set 2 : test #

Total comments: 6

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -206 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 6 chunks +33 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js View 9 chunks +9 lines, -144 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/HistoryInput.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js View 1 chunk +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2377193004 Patch 40001

Messages

Total messages: 14 (8 generated)
dgozman
Could you please take a look? https://codereview.chromium.org/2393763002/diff/20001/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js File third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js (left): https://codereview.chromium.org/2393763002/diff/20001/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js#oldcode626 third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js:626: var anchorBox = ...
4 years, 2 months ago (2016-10-05 02:34:49 UTC) #2
lushnikov
good patch! thank you, lgtm https://codereview.chromium.org/2393763002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js (right): https://codereview.chromium.org/2393763002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js#newcode110 third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js:110: for (var parent = ...
4 years, 2 months ago (2016-10-05 16:03:59 UTC) #3
dgozman
https://codereview.chromium.org/2393763002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js (right): https://codereview.chromium.org/2393763002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js#newcode110 third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js:110: for (var parent = element; parent; parent = parent.scrollParent) ...
4 years, 2 months ago (2016-10-05 17:29:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393763002/40001
4 years, 2 months ago (2016-10-08 14:49:17 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-08 14:53:49 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 14:55:31 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/020999d2033e17c3a14f779a0ae845530a71898f
Cr-Commit-Position: refs/heads/master@{#424080}

Powered by Google App Engine
This is Rietveld 408576698