third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js - Issue 2393763002: [DevTools] Cleanup DOMExtension.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js

Issue 2393763002: [DevTools] Cleanup DOMExtension.js. (Closed)

Patch Set: review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js

index 60d17ce143aa1d4d8e84f7a9918444ce14cb6595..fea94b257369b5cc06f5b12b642c7fcfb61e8162 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js

@@ -11,7 +11,7 @@ WebInspector.SwatchPopoverHelper = function()

this._popover = new WebInspector.Popover();

this._popover.setCanShrink(false);

this._popover.setNoMargins(true);

- this._popover.element.addEventListener("mousedown", consumeEvent, false);

+ this._popover.element.addEventListener("mousedown", (e) => e.consume(), false);

this._hideProxy = this.hide.bind(this, true);

this._boundOnKeyDown = this._onKeyDown.bind(this);