third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js - Issue 2393763002: [DevTools] Cleanup DOMExtension.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js

Issue 2393763002: [DevTools] Cleanup DOMExtension.js. (Closed)

Patch Set: review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js b/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js

index 88b1c715b82e048e255f9d9f50713bfc6dc1d094..99c432ca8991e90d7144b2f0620d2b4622dfb71f 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js

@@ -61,7 +61,7 @@ WebInspector.SoftContextMenu.prototype = {

this.element.style.left = (this._parentMenu ? x - subMenuOverlap : x) + "px";

this._contextMenuElement.tabIndex = 0;

- this._contextMenuElement.addEventListener("mouseup", consumeEvent, false);

+ this._contextMenuElement.addEventListener("mouseup", (e) => e.consume(), false);

this._contextMenuElement.addEventListener("keydown", this._menuKeyDown.bind(this), false);

for (var i = 0; i < this._items.length; ++i)