third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 2393763002: [DevTools] Cleanup DOMExtension.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2393763002: [DevTools] Cleanup DOMExtension.js. (Closed)

Patch Set: review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

index d02ba92b5bad95837e452a69c19179134c43aaf4..94e32e09bd52bfdf29111f3d94c984d87c64ad15 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -1306,7 +1306,7 @@ WebInspector.TimelineUIUtils.InvalidationsGroupElement.prototype = {

for (var i = 0; i < invalidations.length; i++) {

var invalidation = invalidations[i];

var invalidationNode = this._createInvalidationNode(invalidation, false);

- invalidationNode.addEventListener("click", consumeEvent, false);

+ invalidationNode.addEventListener("click", (e) => e.consume(), false);

if (invalidationNode && !invalidationNodeIdMap[invalidation.nodeId]) {

invalidationNodes.push(invalidationNode);

invalidationNodeIdMap[invalidation.nodeId] = true;