Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/HistoryInput.js

Issue 2393763002: [DevTools] Cleanup DOMExtension.js. (Closed)
Patch Set: review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/HistoryInput.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/HistoryInput.js b/third_party/WebKit/Source/devtools/front_end/ui/HistoryInput.js
index 54daad1e1836375e4ca2b68186b965b9167d9560..f8ab8a5626bdb33f5785447a39ded532b1f7a9d2 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/HistoryInput.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/HistoryInput.js
@@ -47,12 +47,12 @@ WebInspector.HistoryInput.prototype = {
if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Up.code) {
this._historyPosition = Math.max(this._historyPosition - 1, 0);
this.value = this._history[this._historyPosition];
- this.dispatchEvent(createEvent("input", true, true));
+ this.dispatchEvent(new Event("input", {"bubbles": true, "cancelable": true}));
event.consume(true);
} else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Down.code) {
this._historyPosition = Math.min(this._historyPosition + 1, this._history.length - 1);
this.value = this._history[this._historyPosition];
- this.dispatchEvent(createEvent("input", true, true));
+ this.dispatchEvent(new Event("input", {"bubbles": true, "cancelable": true}));
event.consume(true);
} else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Enter.code) {
this._saveToHistory();

Powered by Google App Engine
This is Rietveld 408576698