Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js

Issue 2393763002: [DevTools] Cleanup DOMExtension.js. (Closed)
Patch Set: review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js b/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
index 5b67223fe51540116a3caf40614f3e7345cbce86..cbd8277852166192a46c0bcfb31b0e426472fd47 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
@@ -207,8 +207,8 @@ WebInspector.ComputedStyleWidget.prototype = {
var trace = propertyTraces.get(propertyName);
if (trace) {
var activeProperty = this._renderPropertyTrace(cssModel, matchedStyles, nodeStyle.node, treeElement, trace);
- treeElement.listItemElement.addEventListener("mousedown", consumeEvent, false);
- treeElement.listItemElement.addEventListener("dblclick", consumeEvent, false);
+ treeElement.listItemElement.addEventListener("mousedown", (e) => e.consume(), false);
+ treeElement.listItemElement.addEventListener("dblclick", (e) => e.consume(), false);
treeElement.listItemElement.addEventListener("click", handleClick.bind(null, treeElement), false);
var gotoSourceElement = propertyValueElement.createChild("div", "goto-source-icon");
gotoSourceElement.addEventListener("click", this._navigateToSource.bind(this, activeProperty));
@@ -243,7 +243,7 @@ WebInspector.ComputedStyleWidget.prototype = {
treeElement.expand();
else
treeElement.collapse();
- consumeEvent(event);
+ event.consume();
}
},

Powered by Google App Engine
This is Rietveld 408576698