Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Heap::AllocateStringFromOneByte() and major part of its callers handlified.

R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20846

[Igor Sheludko, 2014-04-17 11:18:36]

PTAL

[Yang, 2014-04-17 12:28:45]

LGTM with one nit.

https://codereview.chromium.org/239243018/diff/1/src/factory.h
File src/factory.h (right):

https://codereview.chromium.org/239243018/diff/1/src/factory.h#newcode127
src/factory.h:127: const char (&str)[N],
Wow. I did not know you could use array size as implicit template argument.
Nice.

https://codereview.chromium.org/239243018/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://codereview.chromium.org/239243018/diff/1/src/jsregexp.cc#newcode111
src/jsregexp.cc:111: isolate->Throw(*regexp_err);
We could use the handle version:
return isolate->Throw<Object>(regexp_err);

[Igor Sheludko, 2014-04-17 12:59:03]

Addressed comment + some cleanup.

https://codereview.chromium.org/239243018/diff/1/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/239243018/diff/1/src/d8.cc#newcode985
src/d8.cc:985:
factory->NewStringFromUtf8(i::CStrVector(js_args[j])).ToHandleChecked();
Not sure about this place, can it fail here?

https://codereview.chromium.org/239243018/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://codereview.chromium.org/239243018/diff/1/src/jsregexp.cc#newcode111
src/jsregexp.cc:111: isolate->Throw(*regexp_err);
On 2014/04/17 12:28:46, Yang wrote:
> We could use the handle version:
> return isolate->Throw<Object>(regexp_err);

Done.

[Yang, 2014-04-17 13:00:15]

lgtm.

https://codereview.chromium.org/239243018/diff/1/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/239243018/diff/1/src/d8.cc#newcode985
src/d8.cc:985:
factory->NewStringFromUtf8(i::CStrVector(js_args[j])).ToHandleChecked();
On 2014/04/17 12:59:03, Igor Sheludko wrote:
> Not sure about this place, can it fail here?

Very unlikely I guess.

[Igor Sheludko, 2014-04-17 13:27:40]

Committed patchset #2 manually as r20846 (presubmit successful).