src/ast.cc - Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index b9e0b38561868236174684e3c39b80cdf9ec935e..a1037f79163c90e48d5ac4125b868f670ddec96a 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -1179,7 +1179,7 @@ Handle<String> Literal::ToString() {

} else {

str = DoubleToCString(value_->Number(), buffer);

}

- return isolate_->factory()->NewStringFromAscii(CStrVector(str));

+ return isolate_->factory()->NewStringFromAsciiChecked(str);

}

« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »