test/cctest/test-compiler.cc - Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-compiler.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-compiler.cc

diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc

index 6e9a17cec84a5188c7168c04b5801e5a9d799b67..cc9258aa15643e40be6b30ae9c66b92d334c85b5 100644

--- a/test/cctest/test-compiler.cc

+++ b/test/cctest/test-compiler.cc

@@ -56,8 +56,8 @@ static void SetGlobalProperty(const char* name, Object* value) {

static Handle<JSFunction> Compile(const char* source) {

Isolate* isolate = CcTest::i_isolate();

- Handle<String> source_code(

- isolate->factory()->NewStringFromUtf8(CStrVector(source)));

+ Handle<String> source_code = isolate->factory()->NewStringFromUtf8(

+ CStrVector(source)).ToHandleChecked();

Handle<SharedFunctionInfo> shared_function =

Compiler::CompileScript(source_code,

Handle<String>(),

« no previous file with comments | « test/cctest/test-alloc.cc ('k') | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »