test/cctest/test-hashing.cc - Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-hashing.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-hashing.cc

diff --git a/test/cctest/test-hashing.cc b/test/cctest/test-hashing.cc

index 66ee04158ff455ed3380778d44876da0ad3d82fb..9a7d61ddd88a58415dcdb467cdf167102269a35e 100644

--- a/test/cctest/test-hashing.cc

+++ b/test/cctest/test-hashing.cc

@@ -203,7 +203,8 @@ void check(i::Vector<const uint8_t> string) {

CHECK(code->IsCode());

HASH_FUNCTION hash = FUNCTION_CAST<HASH_FUNCTION>(code->entry());

- Handle<String> v8_string = factory->NewStringFromOneByte(string);

+ Handle<String> v8_string =

+ factory->NewStringFromOneByte(string).ToHandleChecked();

v8_string->set_hash_field(String::kEmptyHashField);

#ifdef USE_SIMULATOR

uint32_t codegen_hash = static_cast<uint32_t>(

« no previous file with comments | « test/cctest/test-func-name-inference.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »