test/cctest/test-func-name-inference.cc - Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-func-name-inference.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-func-name-inference.cc

diff --git a/test/cctest/test-func-name-inference.cc b/test/cctest/test-func-name-inference.cc

index d7c50830503ce49944d5b5a6e2d9e4579395f954..f42690587502aee6abe431f600852c1590ea599e 100644

--- a/test/cctest/test-func-name-inference.cc

+++ b/test/cctest/test-func-name-inference.cc

@@ -70,7 +70,7 @@ static void CheckFunctionName(v8::Handle<v8::Script> script,

// Find the position of a given func source substring in the source.

Handle<String> func_pos_str =

- factory->NewStringFromAscii(CStrVector(func_pos_src));

+ factory->NewStringFromAsciiChecked(func_pos_src);

int func_pos = Runtime::StringMatch(isolate,

script_src,

func_pos_str,

« no previous file with comments | « test/cctest/test-cpu-profiler.cc ('k') | test/cctest/test-hashing.cc » ('j') | no next file with comments »