test/cctest/test-cpu-profiler.cc - Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-cpu-profiler.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-cpu-profiler.cc

diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc

index 9bcefa4b86b3bb67d48f2a0cd2681d2b9d8a0b85..d3fcf7d7edee3ea842834152a547c9618bdab92e 100644

--- a/test/cctest/test-cpu-profiler.cc

+++ b/test/cctest/test-cpu-profiler.cc

@@ -148,8 +148,7 @@ TEST(CodeEvents) {

// Enqueue code creation events.

const char* aaa_str = "aaa";

- i::Handle<i::String> aaa_name = factory->NewStringFromAscii(

- i::Vector<const char>(aaa_str, i::StrLength(aaa_str)));

+ i::Handle<i::String> aaa_name = factory->NewStringFromAsciiChecked(aaa_str);

profiler.CodeCreateEvent(i::Logger::FUNCTION_TAG, aaa_code, *aaa_name);

profiler.CodeCreateEvent(i::Logger::BUILTIN_TAG, comment_code, "comment");

profiler.CodeCreateEvent(i::Logger::STUB_TAG, args5_code, 5);

« no previous file with comments | « test/cctest/test-compiler.cc ('k') | test/cctest/test-func-name-inference.cc » ('j') | no next file with comments »