Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 2391043005: [crankshaft] Remove HLoadKeyedGeneric and use HCallWithDescriptor to call KeyedLoadIC. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove HLoadKeyedGeneric and use HCallWithDescriptor to call KeyedLoadIC. ... because the latter automatically respects the desired calling convention. BUG=v8:5408 Committed: https://crrev.com/42884efd19ff90b18e2cd9bbb2ca9dcd4aa3e63c Cr-Commit-Position: refs/heads/master@{#40223}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -638 lines) Patch
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -21 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 chunks +0 lines, -31 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 5 chunks +27 lines, -17 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 1 7 chunks +23 lines, -46 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 2 chunks +10 lines, -17 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 2 chunks +0 lines, -28 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 2 chunks +0 lines, -26 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (15 generated)
Igor Sheludko
PTAL https://codereview.chromium.org/2391043005/diff/1/src/crankshaft/hydrogen-instructions.cc File src/crankshaft/hydrogen-instructions.cc (right): https://codereview.chromium.org/2391043005/diff/1/src/crankshaft/hydrogen-instructions.cc#newcode2974 src/crankshaft/hydrogen-instructions.cc:2974: HValue* HCallWithDescriptor::Canonicalize() { Non-trivial change.
4 years, 2 months ago (2016-10-12 11:07:38 UTC) #6
Jarin
lgtm
4 years, 2 months ago (2016-10-12 12:52:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391043005/20001
4 years, 2 months ago (2016-10-12 13:45:28 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 13:48:15 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 13:48:51 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42884efd19ff90b18e2cd9bbb2ca9dcd4aa3e63c
Cr-Commit-Position: refs/heads/master@{#40223}

Powered by Google App Engine
This is Rietveld 408576698