Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2389133007: [crankshaft] Exclude context parameter from HCallWithDescriptor arguments. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Exclude context parameter from HCallWithDescriptor arguments. Thus the parameter indices defined in respective CallInterfaceDescriptor can be used for querying parameters. BUG= Committed: https://crrev.com/ca680a68eefd2a2179bbe89a9719b8c99ef9ab9d Cr-Commit-Position: refs/heads/master@{#40222}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -43 lines) Patch
M src/code-stubs-hydrogen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 23 chunks +25 lines, -32 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 1 4 chunks +12 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (15 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-12 11:07:23 UTC) #6
Jarin
lgtm.
4 years, 2 months ago (2016-10-12 12:45:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389133007/20001
4 years, 2 months ago (2016-10-12 13:25:09 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 13:30:11 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 13:30:32 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca680a68eefd2a2179bbe89a9719b8c99ef9ab9d
Cr-Commit-Position: refs/heads/master@{#40222}

Powered by Google App Engine
This is Rietveld 408576698