Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/crankshaft/s390/lithium-s390.cc

Issue 2391043005: [crankshaft] Remove HLoadKeyedGeneric and use HCallWithDescriptor to call KeyedLoadIC. (Closed)
Patch Set: Rebasing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/s390/lithium-s390.h ('k') | src/crankshaft/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/s390/lithium-s390.h" 5 #include "src/crankshaft/s390/lithium-s390.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/crankshaft/hydrogen-osr.h" 9 #include "src/crankshaft/hydrogen-osr.h"
10 #include "src/crankshaft/lithium-inl.h" 10 #include "src/crankshaft/lithium-inl.h"
(...skipping 1872 matching lines...) Expand 10 before | Expand all | Expand 10 after
1883 instr->RequiresHoleCheck() || 1883 instr->RequiresHoleCheck() ||
1884 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub()); 1884 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub());
1885 } 1885 }
1886 1886
1887 if (needs_environment) { 1887 if (needs_environment) {
1888 result = AssignEnvironment(result); 1888 result = AssignEnvironment(result);
1889 } 1889 }
1890 return result; 1890 return result;
1891 } 1891 }
1892 1892
1893 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
1894 LOperand* context = UseFixed(instr->context(), cp);
1895 LOperand* object =
1896 UseFixed(instr->object(), LoadDescriptor::ReceiverRegister());
1897 LOperand* key = UseFixed(instr->key(), LoadDescriptor::NameRegister());
1898 LOperand* vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
1899
1900 LInstruction* result = DefineFixed(
1901 new (zone()) LLoadKeyedGeneric(context, object, key, vector), r2);
1902 return MarkAsCall(result, instr);
1903 }
1904
1905 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) { 1893 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
1906 if (!instr->is_fixed_typed_array()) { 1894 if (!instr->is_fixed_typed_array()) {
1907 DCHECK(instr->elements()->representation().IsTagged()); 1895 DCHECK(instr->elements()->representation().IsTagged());
1908 bool needs_write_barrier = instr->NeedsWriteBarrier(); 1896 bool needs_write_barrier = instr->NeedsWriteBarrier();
1909 LOperand* object = NULL; 1897 LOperand* object = NULL;
1910 LOperand* key = NULL; 1898 LOperand* key = NULL;
1911 LOperand* val = NULL; 1899 LOperand* val = NULL;
1912 1900
1913 if (instr->value()->representation().IsDouble()) { 1901 if (instr->value()->representation().IsDouble()) {
1914 object = UseRegisterAtStart(instr->elements()); 1902 object = UseRegisterAtStart(instr->elements());
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
2200 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2188 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2201 LOperand* object = UseRegister(instr->object()); 2189 LOperand* object = UseRegister(instr->object());
2202 LOperand* index = UseTempRegister(instr->index()); 2190 LOperand* index = UseTempRegister(instr->index());
2203 LLoadFieldByIndex* load = new (zone()) LLoadFieldByIndex(object, index); 2191 LLoadFieldByIndex* load = new (zone()) LLoadFieldByIndex(object, index);
2204 LInstruction* result = DefineSameAsFirst(load); 2192 LInstruction* result = DefineSameAsFirst(load);
2205 return AssignPointerMap(result); 2193 return AssignPointerMap(result);
2206 } 2194 }
2207 2195
2208 } // namespace internal 2196 } // namespace internal
2209 } // namespace v8 2197 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/s390/lithium-s390.h ('k') | src/crankshaft/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698