Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: src/crankshaft/arm/lithium-arm.cc

Issue 2391043005: [crankshaft] Remove HLoadKeyedGeneric and use HCallWithDescriptor to call KeyedLoadIC. (Closed)
Patch Set: Rebasing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm/lithium-arm.h ('k') | src/crankshaft/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm/lithium-arm.h" 5 #include "src/crankshaft/arm/lithium-arm.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/crankshaft/arm/lithium-codegen-arm.h" 9 #include "src/crankshaft/arm/lithium-codegen-arm.h"
10 #include "src/crankshaft/hydrogen-osr.h" 10 #include "src/crankshaft/hydrogen-osr.h"
(...skipping 2075 matching lines...) Expand 10 before | Expand all | Expand 10 after
2086 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub()); 2086 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub());
2087 } 2087 }
2088 2088
2089 if (needs_environment) { 2089 if (needs_environment) {
2090 result = AssignEnvironment(result); 2090 result = AssignEnvironment(result);
2091 } 2091 }
2092 return result; 2092 return result;
2093 } 2093 }
2094 2094
2095 2095
2096 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
2097 LOperand* context = UseFixed(instr->context(), cp);
2098 LOperand* object =
2099 UseFixed(instr->object(), LoadDescriptor::ReceiverRegister());
2100 LOperand* key = UseFixed(instr->key(), LoadDescriptor::NameRegister());
2101 LOperand* vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2102
2103 LInstruction* result =
2104 DefineFixed(new(zone()) LLoadKeyedGeneric(context, object, key, vector),
2105 r0);
2106 return MarkAsCall(result, instr);
2107 }
2108
2109
2110 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) { 2096 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
2111 if (!instr->is_fixed_typed_array()) { 2097 if (!instr->is_fixed_typed_array()) {
2112 DCHECK(instr->elements()->representation().IsTagged()); 2098 DCHECK(instr->elements()->representation().IsTagged());
2113 bool needs_write_barrier = instr->NeedsWriteBarrier(); 2099 bool needs_write_barrier = instr->NeedsWriteBarrier();
2114 LOperand* object = NULL; 2100 LOperand* object = NULL;
2115 LOperand* key = NULL; 2101 LOperand* key = NULL;
2116 LOperand* val = NULL; 2102 LOperand* val = NULL;
2117 2103
2118 if (instr->value()->representation().IsDouble()) { 2104 if (instr->value()->representation().IsDouble()) {
2119 object = UseRegisterAtStart(instr->elements()); 2105 object = UseRegisterAtStart(instr->elements());
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
2432 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2418 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2433 LOperand* object = UseRegister(instr->object()); 2419 LOperand* object = UseRegister(instr->object());
2434 LOperand* index = UseTempRegister(instr->index()); 2420 LOperand* index = UseTempRegister(instr->index());
2435 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2421 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2436 LInstruction* result = DefineSameAsFirst(load); 2422 LInstruction* result = DefineSameAsFirst(load);
2437 return AssignPointerMap(result); 2423 return AssignPointerMap(result);
2438 } 2424 }
2439 2425
2440 } // namespace internal 2426 } // namespace internal
2441 } // namespace v8 2427 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/arm/lithium-arm.h ('k') | src/crankshaft/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698