Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/crankshaft/mips/lithium-mips.cc

Issue 2391043005: [crankshaft] Remove HLoadKeyedGeneric and use HCallWithDescriptor to call KeyedLoadIC. (Closed)
Patch Set: Rebasing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/mips/lithium-mips.h ('k') | src/crankshaft/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/mips/lithium-mips.h" 5 #include "src/crankshaft/mips/lithium-mips.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_MIPS 9 #if V8_TARGET_ARCH_MIPS
10 10
(...skipping 2022 matching lines...) Expand 10 before | Expand all | Expand 10 after
2033 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub()); 2033 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub());
2034 } 2034 }
2035 2035
2036 if (needs_environment) { 2036 if (needs_environment) {
2037 result = AssignEnvironment(result); 2037 result = AssignEnvironment(result);
2038 } 2038 }
2039 return result; 2039 return result;
2040 } 2040 }
2041 2041
2042 2042
2043 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
2044 LOperand* context = UseFixed(instr->context(), cp);
2045 LOperand* object =
2046 UseFixed(instr->object(), LoadDescriptor::ReceiverRegister());
2047 LOperand* key = UseFixed(instr->key(), LoadDescriptor::NameRegister());
2048 LOperand* vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2049
2050 LInstruction* result =
2051 DefineFixed(new(zone()) LLoadKeyedGeneric(context, object, key, vector),
2052 v0);
2053 return MarkAsCall(result, instr);
2054 }
2055
2056
2057 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) { 2043 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
2058 if (!instr->is_fixed_typed_array()) { 2044 if (!instr->is_fixed_typed_array()) {
2059 DCHECK(instr->elements()->representation().IsTagged()); 2045 DCHECK(instr->elements()->representation().IsTagged());
2060 bool needs_write_barrier = instr->NeedsWriteBarrier(); 2046 bool needs_write_barrier = instr->NeedsWriteBarrier();
2061 LOperand* object = NULL; 2047 LOperand* object = NULL;
2062 LOperand* val = NULL; 2048 LOperand* val = NULL;
2063 LOperand* key = NULL; 2049 LOperand* key = NULL;
2064 2050
2065 if (instr->value()->representation().IsDouble()) { 2051 if (instr->value()->representation().IsDouble()) {
2066 object = UseRegisterAtStart(instr->elements()); 2052 object = UseRegisterAtStart(instr->elements());
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
2381 LOperand* index = UseTempRegister(instr->index()); 2367 LOperand* index = UseTempRegister(instr->index());
2382 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2368 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2383 LInstruction* result = DefineSameAsFirst(load); 2369 LInstruction* result = DefineSameAsFirst(load);
2384 return AssignPointerMap(result); 2370 return AssignPointerMap(result);
2385 } 2371 }
2386 2372
2387 } // namespace internal 2373 } // namespace internal
2388 } // namespace v8 2374 } // namespace v8
2389 2375
2390 #endif // V8_TARGET_ARCH_MIPS 2376 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/crankshaft/mips/lithium-mips.h ('k') | src/crankshaft/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698