Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Side by Side Diff: src/crankshaft/mips64/lithium-mips64.cc

Issue 2391043005: [crankshaft] Remove HLoadKeyedGeneric and use HCallWithDescriptor to call KeyedLoadIC. (Closed)
Patch Set: Rebasing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/mips64/lithium-mips64.h ('k') | src/crankshaft/ppc/lithium-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/mips64/lithium-mips64.h" 5 #include "src/crankshaft/mips64/lithium-mips64.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_MIPS64 9 #if V8_TARGET_ARCH_MIPS64
10 10
(...skipping 2026 matching lines...) Expand 10 before | Expand all | Expand 10 after
2037 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub()); 2037 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub());
2038 } 2038 }
2039 2039
2040 if (needs_environment) { 2040 if (needs_environment) {
2041 result = AssignEnvironment(result); 2041 result = AssignEnvironment(result);
2042 } 2042 }
2043 return result; 2043 return result;
2044 } 2044 }
2045 2045
2046 2046
2047 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
2048 LOperand* context = UseFixed(instr->context(), cp);
2049 LOperand* object =
2050 UseFixed(instr->object(), LoadDescriptor::ReceiverRegister());
2051 LOperand* key = UseFixed(instr->key(), LoadDescriptor::NameRegister());
2052 LOperand* vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2053
2054 LInstruction* result =
2055 DefineFixed(new(zone()) LLoadKeyedGeneric(context, object, key, vector),
2056 v0);
2057 return MarkAsCall(result, instr);
2058 }
2059
2060
2061 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) { 2047 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
2062 if (!instr->is_fixed_typed_array()) { 2048 if (!instr->is_fixed_typed_array()) {
2063 DCHECK(instr->elements()->representation().IsTagged()); 2049 DCHECK(instr->elements()->representation().IsTagged());
2064 bool needs_write_barrier = instr->NeedsWriteBarrier(); 2050 bool needs_write_barrier = instr->NeedsWriteBarrier();
2065 LOperand* object = NULL; 2051 LOperand* object = NULL;
2066 LOperand* val = NULL; 2052 LOperand* val = NULL;
2067 LOperand* key = NULL; 2053 LOperand* key = NULL;
2068 2054
2069 if (instr->value()->representation().IsDouble()) { 2055 if (instr->value()->representation().IsDouble()) {
2070 object = UseRegisterAtStart(instr->elements()); 2056 object = UseRegisterAtStart(instr->elements());
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
2386 LOperand* index = UseTempRegister(instr->index()); 2372 LOperand* index = UseTempRegister(instr->index());
2387 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2373 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2388 LInstruction* result = DefineSameAsFirst(load); 2374 LInstruction* result = DefineSameAsFirst(load);
2389 return AssignPointerMap(result); 2375 return AssignPointerMap(result);
2390 } 2376 }
2391 2377
2392 } // namespace internal 2378 } // namespace internal
2393 } // namespace v8 2379 } // namespace v8
2394 2380
2395 #endif // V8_TARGET_ARCH_MIPS64 2381 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/crankshaft/mips64/lithium-mips64.h ('k') | src/crankshaft/ppc/lithium-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698