Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2388653002: gpu: Add CHROMIUM_texture_from_image spec and fence support.

Created:
4 years, 2 months ago by reveman
Modified:
4 years, 1 month ago
Reviewers:
fooishbar
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Add CHROMIUM_texture_from_image spec and fence support. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : rebase #

Patch Set 4 : wait for fence #

Patch Set 5 : ozone fix #

Patch Set 6 : rebase #

Total comments: 2

Patch Set 7 : media/gpu/vaapi_drm_picture.cc #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -100 lines) Patch
M cc/raster/one_copy_raster_buffer_provider.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/test/test_gles2_interface.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M cc/test/test_gles2_interface.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M components/display_compositor/buffer_queue.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/display_compositor/buffer_queue_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/exo/buffer.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A gpu/GLES2/extensions/CHROMIUM/CHROMIUM_texture_from_image.txt View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 7 8 9 6 chunks +22 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 2 3 4 5 6 7 8 9 12 chunks +12 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/texture_image_factory.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/vaapi_drm_picture.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/vaapi_tfp_picture.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/video_overlay_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_image_egl.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_egl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +8 lines, -1 line 0 comments Download
M ui/gl/gl_image_glx.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_glx.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.mm View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_memory.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_memory.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_stub.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_stub.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ui/gl/gl_image_surface_texture.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_surface_texture.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/test/gl_image_test_template.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (2 generated)
fooishbar
https://codereview.chromium.org/2388653002/diff/100001/ui/gl/gl_image.h File ui/gl/gl_image.h (right): https://codereview.chromium.org/2388653002/diff/100001/ui/gl/gl_image.h#newcode48 ui/gl/gl_image.h:48: virtual bool BindTexImage(unsigned target, GLFence* fence) = 0; media/gpu/vaapi_drm_picture.cc ...
4 years, 2 months ago (2016-10-11 11:33:32 UTC) #3
reveman
4 years, 2 months ago (2016-10-11 15:04:48 UTC) #4 
https://codereview.chromium.org/2388653002/diff/100001/ui/gl/gl_image.h
File ui/gl/gl_image.h (right):

https://codereview.chromium.org/2388653002/diff/100001/ui/gl/gl_image.h#newco...
ui/gl/gl_image.h:48: virtual bool BindTexImage(unsigned target, GLFence* fence)
= 0;
On 2016/10/11 at 11:33:32, fooishbar wrote:
> media/gpu/vaapi_drm_picture.cc needs an update here (line 89)

Done

Powered by Google App Engine
This is Rietveld 408576698