Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2384243003: ui: Add libsync GLFence implementation.

Created:
4 years, 2 months ago by reveman
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Add libsync GLFence implementation. This allows Android explicit synchronization fences to be used with the GpuFence framework. BUG=653908 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : -Wno-implicit-function-declaration #

Patch Set 4 : GpuChannel::CreateFenceForGpuFence #

Patch Set 5 : rebase + ipc fix + plog #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -24 lines) Patch
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 2 3 4 5 6 3 chunks +10 lines, -1 line 0 comments Download
M content/child/child_gpu_memory_buffer_manager.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M gpu/ipc/client/BUILD.gn View 1 2 3 4 5 6 3 chunks +11 lines, -0 lines 0 comments Download
M gpu/ipc/client/DEPS View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M gpu/ipc/client/gpu_channel_host.cc View 1 2 3 4 5 1 chunk +10 lines, -2 lines 0 comments Download
M gpu/ipc/client/gpu_fence_impl.h View 1 2 3 4 5 6 3 chunks +3 lines, -5 lines 0 comments Download
M gpu/ipc/client/gpu_fence_impl.cc View 1 2 3 4 5 6 2 chunks +26 lines, -13 lines 0 comments Download
A gpu/ipc/client/gpu_fence_impl_libsync.h View 1 2 3 4 5 6 1 chunk +32 lines, -0 lines 0 comments Download
A gpu/ipc/client/gpu_fence_impl_libsync.cc View 1 2 3 4 5 6 1 chunk +35 lines, -0 lines 0 comments Download
A gpu/ipc/client/gpu_fence_impl_shared_event.h View 1 2 3 4 5 6 1 chunk +34 lines, -0 lines 0 comments Download
A gpu/ipc/client/gpu_fence_impl_shared_event.cc View 1 2 3 4 5 6 1 chunk +35 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/libsync/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/gpu_fence.h View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits_macros.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/shared_event.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/shared_event.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/DEPS View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
A ui/gl/gl_fence_libsync.h View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A ui/gl/gl_fence_libsync.cc View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (2 generated)
reveman
Description was changed from ========== ui: Add libsync GLFence implementation. BUG= ========== to ========== ui: ...
4 years, 2 months ago (2016-10-04 17:14:47 UTC) #1
reveman
4 years, 2 months ago (2016-10-23 22:56:12 UTC) #2 
Description was changed from

==========
ui: Add libsync GLFence implementation.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
ui: Add libsync GLFence implementation.

This allows Android explicit synchronization fences to be used
with the GpuFence framework.

BUG=653908
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Powered by Google App Engine
This is Rietveld 408576698