Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2383533002: Make logging of user actions consistent with histograms for OTR. (Closed)

Created:
4 years, 2 months ago by Alexei Svitkine (slow)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, asvitkine+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, android-webview-reviews_chromium.org, khushalsagar+watch-blimp_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make logging of user actions consistent with histograms for OTR. Previously, we would not record user actions in UMA when an OTR (Incognito) window was active. However, since user actions don't contain any PII it was just causing a confusing discrepancy in counts when compared to histograms. This CL makes them consistent by making user actions be logged regardless of the OTR state. BUG=604001 TBR=sgurun@chromium.org, wez@chromium.org, rohitrao@chromium.org Committed: https://crrev.com/7573bd00c132474546bb4f23b123c2612fce3731 Cr-Commit-Position: refs/heads/master@{#422133}

Patch Set 1 #

Patch Set 2 : Also change the cast client. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -50 lines) Patch
M android_webview/browser/aw_metrics_service_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_metrics_service_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M blimp/engine/app/blimp_metrics_service_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/app/blimp_metrics_service_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M components/metrics/metrics_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/metrics/metrics_service.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M components/metrics/metrics_service_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/metrics/test_metrics_service_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/test_metrics_service_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 29 (20 generated)
Alexei Svitkine (slow)
4 years, 2 months ago (2016-09-29 14:55:19 UTC) #6
Alexei Svitkine (slow)
Should be ready for review now.
4 years, 2 months ago (2016-09-29 16:27:38 UTC) #15
rkaplow
lgtm
4 years, 2 months ago (2016-09-29 16:59:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383533002/20001
4 years, 2 months ago (2016-09-30 15:59:30 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/270679)
4 years, 2 months ago (2016-09-30 16:04:59 UTC) #20
Alexei Svitkine (slow)
+TBR=sgurun@chromium.org, wez@chromium.org, rohitrao@chromium.org for changes in MetricsServiceClient implementations in android_webview, blimp and ios
4 years, 2 months ago (2016-09-30 16:25:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383533002/20001
4 years, 2 months ago (2016-09-30 16:26:31 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 17:00:26 UTC) #27
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 17:06:30 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7573bd00c132474546bb4f23b123c2612fce3731
Cr-Commit-Position: refs/heads/master@{#422133}

Powered by Google App Engine
This is Rietveld 408576698