chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 2383533002: Make logging of user actions consistent with histograms for OTR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2383533002: Make logging of user actions consistent with histograms for OTR. (Closed)

Patch Set: Also change the cast client. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index b1af4ef6ecbcb0294a9c5476fb4f538339abfe9b..27602fa8b0f8a25c51f190608514b019215adf32 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -312,10 +312,6 @@ void ChromeMetricsServiceClient::SetMetricsClientId(

crash_keys::SetMetricsClientIdFromGUID(client_id);

}

-bool ChromeMetricsServiceClient::IsOffTheRecordSessionActive() {

- return chrome::IsIncognitoSessionActive();

int32_t ChromeMetricsServiceClient::GetProduct() {

return metrics::ChromeUserMetricsExtension::CHROME;

}