Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: components/metrics/metrics_service.cc

Issue 2383533002: Make logging of user actions consistent with histograms for OTR. (Closed)
Patch Set: Also change the cast client. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_service.h ('k') | components/metrics/metrics_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_service.cc
diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc
index f73b04992a8f35bd4abea2b7bf1de6ef4e4f0faf..2acc9cb0b88cbec1f0538b42147f7c800af98958 100644
--- a/components/metrics/metrics_service.cc
+++ b/components/metrics/metrics_service.cc
@@ -654,9 +654,6 @@ void MetricsService::InitializeMetricsState() {
}
void MetricsService::OnUserAction(const std::string& action) {
- if (!ShouldLogEvents())
- return;
-
log_manager_.current_log()->RecordUserAction(action);
HandleIdleSinceLastTransmission(false);
}
@@ -1200,13 +1197,6 @@ void MetricsService::LogCleanShutdown() {
MetricsService::SHUTDOWN_COMPLETE);
}
-bool MetricsService::ShouldLogEvents() {
- // We simply don't log events to UMA if there is a single incognito
- // session visible. The problem is that we always notify using the original
- // profile in order to simplify notification processing.
- return !client_->IsOffTheRecordSessionActive();
-}
-
void MetricsService::RecordBooleanPrefValue(const char* path, bool value) {
DCHECK(IsSingleThreaded());
local_state_->SetBoolean(path, value);
« no previous file with comments | « components/metrics/metrics_service.h ('k') | components/metrics/metrics_service_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698