android_webview/browser/aw_metrics_service_client.cc - Issue 2383533002: Make logging of user actions consistent with histograms for OTR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_metrics_service_client.cc

Issue 2383533002: Make logging of user actions consistent with histograms for OTR. (Closed)

Patch Set: Also change the cast client. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_metrics_service_client.cc

diff --git a/android_webview/browser/aw_metrics_service_client.cc b/android_webview/browser/aw_metrics_service_client.cc

index 7ef4741146ef803f988f6d5148a93982cc89eecf..588818d005991d6077e50ab7122598e8efb6c2e0 100644

--- a/android_webview/browser/aw_metrics_service_client.cc

+++ b/android_webview/browser/aw_metrics_service_client.cc

@@ -164,11 +164,6 @@ metrics::MetricsService* AwMetricsServiceClient::GetMetricsService() {

void AwMetricsServiceClient::SetMetricsClientId(const std::string& client_id) {}

-bool AwMetricsServiceClient::IsOffTheRecordSessionActive() {

- // WebView has no incognito mode.

- return false;

int32_t AwMetricsServiceClient::GetProduct() {

return ::metrics::ChromeUserMetricsExtension::ANDROID_WEBVIEW;

}