blimp/engine/app/blimp_metrics_service_client.cc - Issue 2383533002: Make logging of user actions consistent with histograms for OTR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/app/blimp_metrics_service_client.cc

Issue 2383533002: Make logging of user actions consistent with histograms for OTR. (Closed)

Patch Set: Also change the cast client. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/engine/app/blimp_metrics_service_client.cc

diff --git a/blimp/engine/app/blimp_metrics_service_client.cc b/blimp/engine/app/blimp_metrics_service_client.cc

index 5b25f9349fbaa2c467c459319865ffb06099c0fb..94bad89691d6c784f077f5211ac2b733d203dab4 100644

--- a/blimp/engine/app/blimp_metrics_service_client.cc

+++ b/blimp/engine/app/blimp_metrics_service_client.cc

@@ -94,11 +94,6 @@ metrics::MetricsService* BlimpMetricsServiceClient::GetMetricsService() {

void BlimpMetricsServiceClient::SetMetricsClientId(

const std::string& client_id) {}

-bool BlimpMetricsServiceClient::IsOffTheRecordSessionActive() {

- // Blimp does not have incognito mode.

- return false;

int32_t BlimpMetricsServiceClient::GetProduct() {

// Indicates product family (e.g. Chrome v Android Webview), not reported

// platform (e.g. Chrome_Linux, Chrome_Mac).