chromecast/browser/metrics/cast_metrics_service_client.h - Issue 2383533002: Make logging of user actions consistent with histograms for OTR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 2383533002: Make logging of user actions consistent with histograms for OTR. (Closed)

Patch Set: Also change the cast client. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index 10fee3e4e95d25d89c0a3d5b6b2c85e511d41b75..11ec2241bad2c44a15292f96da6fd9994417a358 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -69,7 +69,6 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient,

// ::metrics::MetricsServiceClient:

::metrics::MetricsService* GetMetricsService() override;

void SetMetricsClientId(const std::string& client_id) override;

- bool IsOffTheRecordSessionActive() override;

int32_t GetProduct() override;

std::string GetApplicationLocale() override;

bool GetBrand(std::string* brand_code) override;