Replace usage of SurfaceId's client_id with FrameSinkId

Replace usage of SurfaceId's client_id with FrameSinkId

This CL mechanically replaces SurfaceClientId with a
FrameSinkId that consists of two components. The second
component is left empty in this CL. In a subsequent CL,
FrameSinkId will be made into a (RenderProcessHost ID,
RoutingID) pair and
GpuProcessTransportFactory::AllocateFrameSinkId will go
away. In Mus+Ash, the FrameSinkId will be the WindowId in
that subsequent CL.

This will allow the display compositor to route new surface
IDs allocated in clients to the appropriate endpoints in
the display compositor host (browser or window server).
Also, these IDs persist across display compositor restarts and so
FrameSinkObservers can be registered in any order
(subsequent CL).

BUG=647852
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/e0f705bd4f61d868a0dcb7a7f1a905b3033ede84
Cr-Commit-Position: refs/heads/master@{#422314}

[Fady Samuel, 2016-09-29 19:02:51]

Description was changed from

==========
Replace usage of client_id to FrameSinkId

BUG=
==========

to

==========
Replace usage of client_id to FrameSinkId

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Fady Samuel, 2016-09-29 19:02:52]

Description was changed from

==========
Replace usage of client_id to FrameSinkId

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Replace usage of client_id to FrameSinkId

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Fady Samuel, 2016-09-29 19:04:41]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 19:05:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 19:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 19:22:17]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-09-30 01:35:01]

Description was changed from

==========
Replace usage of client_id to FrameSinkId

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a FrameSinkId that consists
of two components. The second component is left empty in this CL. In a
subsequent CL, FrameSinkId will be made into a (RenderProcessHost ID, RoutingID)
pair and GpuProcessTransportFactory::AllocateFrameSinkId will go away. In
Mus+Ash, the FrameSinkId will be the WindowId in that subsequent CL.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Fady Samuel, 2016-09-30 01:36:35]

Description was changed from

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a FrameSinkId that consists
of two components. The second component is left empty in this CL. In a
subsequent CL, FrameSinkId will be made into a (RenderProcessHost ID, RoutingID)
pair and GpuProcessTransportFactory::AllocateFrameSinkId will go away. In
Mus+Ash, the FrameSinkId will be the WindowId in that subsequent CL.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL. This will allow the display compositor to route new surface
IDs allocated in clients to the appropriate endpoints in the display compositor
host (browser or window server). Also, these IDs persist across display
compositor restarts.

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Fady Samuel, 2016-09-30 01:36:58]

Description was changed from

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL. This will allow the display compositor to route new surface
IDs allocated in clients to the appropriate endpoints in the display compositor
host (browser or window server). Also, these IDs persist across display
compositor restarts.

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts.

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Fady Samuel, 2016-09-30 01:36:58]

Description was changed from

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL. This will allow the display compositor to route new surface
IDs allocated in clients to the appropriate endpoints in the display compositor
host (browser or window server). Also, these IDs persist across display
compositor restarts.

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts.

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Fady Samuel, 2016-09-30 01:37:33]

Description was changed from

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts.

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts and so
FrameSinkObservers can be registered in any order 
(subsequent CL).

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Fady Samuel, 2016-09-30 01:37:48]

fsamuel@chromium.org changed reviewers:
+ enne@chromium.org

[Fady Samuel, 2016-09-30 13:44:49]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 13:45:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 13:59:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 13:59:59]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Fady Samuel, 2016-09-30 14:02:44]

Description was changed from

==========
Replace usage of SurfaceId's client_id to FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts and so
FrameSinkObservers can be registered in any order 
(subsequent CL).

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replace usage of SurfaceId's client_id with FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts and so
FrameSinkObservers can be registered in any order 
(subsequent CL).

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Fady Samuel, 2016-09-30 14:39:49]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 14:40:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-09-30 14:46:55]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 14:47:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 14:58:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 14:58:29]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Fady Samuel, 2016-09-30 15:31:46]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 15:31:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-09-30 15:31:59]

Description was changed from

==========
Replace usage of SurfaceId's client_id with FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts and so
FrameSinkObservers can be registered in any order 
(subsequent CL).

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replace usage of SurfaceId's client_id with FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts and so 
FrameSinkObservers can be registered in any order 
(subsequent CL).

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-30 15:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 15:43:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-09-30 16:09:05]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 16:09:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 16:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 16:13:48]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-09-30 16:26:02]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 16:26:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 16:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 16:46:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[enne (OOO), 2016-09-30 17:46:58]

lgtm

[Fady Samuel, 2016-09-30 17:51:02]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 17:51:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-09-30 17:52:53]

fsamuel@chromium.org changed reviewers:
+ boliu@chromium.org, dtrainor@chromium.org, jam@chromium.org,
tsepez@chromium.org

[Fady Samuel, 2016-09-30 17:52:54]

+dtrainor@ for blimp
+jam@ for content
+boliu@ for android-y things.
+tsepez@ for ipc

[Tom Sepez, 2016-09-30 18:08:00]

lgtm

[commit-bot: I haz the power, 2016-09-30 18:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 18:12:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-09-30 18:21:15]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-09-30 18:21:29]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2016-09-30 18:21:30]

+sky@ for ui

[commit-bot: I haz the power, 2016-09-30 18:21:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 18:38:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 18:38:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-09-30 18:58:10]

LGTM

https://codereview.chromium.org/2382873002/diff/200001/ui/compositor/composit...
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/2382873002/diff/200001/ui/compositor/composit...
ui/compositor/compositor.cc:85: new
cc::SurfaceIdAllocator(context_factory->AllocateFrameSinkId())),
MakeUnique

[Fady Samuel, 2016-09-30 19:27:49]

PTAL dtrainor@, jam@, boliu@ thanks!

https://codereview.chromium.org/2382873002/diff/200001/ui/compositor/composit...
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/2382873002/diff/200001/ui/compositor/composit...
ui/compositor/compositor.cc:85: new
cc::SurfaceIdAllocator(context_factory->AllocateFrameSinkId())),
On 2016/09/30 18:58:09, sky wrote:
> MakeUnique

Done.

[Fady Samuel, 2016-09-30 19:27:59]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-09-30 19:28:23]

fsamuel@chromium.org changed reviewers:
+ reveman@chromium.org

[Fady Samuel, 2016-09-30 19:28:24]

+reveman@ for exo

[commit-bot: I haz the power, 2016-09-30 19:28:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2016-09-30 19:38:53]

blimp/ lgtm

[commit-bot: I haz the power, 2016-09-30 19:52:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 19:52:01]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[reveman, 2016-09-30 19:55:55]

components/exo lgtm

[Fady Samuel, 2016-09-30 20:31:22]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:32:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:37:24]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[boliu, 2016-09-30 21:06:06]

https://codereview.chromium.org/2382873002/diff/240001/content/browser/render...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/2382873002/diff/240001/content/browser/render...
content/browser/renderer_host/compositor_impl_android.cc:333: bool
BindToClient(cc::OutputFrameSink* client) override {
does this compile? this is still an OutputSurface, not FrameSink?

https://codereview.chromium.org/2382873002/diff/240001/content/browser/render...
File content/browser/renderer_host/context_provider_factory_impl_android.cc
(right):

https://codereview.chromium.org/2382873002/diff/240001/content/browser/render...
content/browser/renderer_host/context_provider_factory_impl_android.cc:139:
return cc::FrameSinkId(next_client_id_, 0 /* sink_id */);
missed ++ ?

[Fady Samuel, 2016-09-30 21:49:30]

PTAL Bo! GOMA is acting up so I haven't been compiling for android every change.

https://codereview.chromium.org/2382873002/diff/240001/content/browser/render...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/2382873002/diff/240001/content/browser/render...
content/browser/renderer_host/compositor_impl_android.cc:333: bool
BindToClient(cc::OutputFrameSink* client) override {
On 2016/09/30 21:06:06, boliu wrote:
> does this compile? this is still an OutputSurface, not FrameSink?

Done.

[Fady Samuel, 2016-09-30 21:49:41]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 21:50:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-09-30 21:51:37]

lgtm

[Fady Samuel, 2016-09-30 22:13:18]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 22:13:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 22:56:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 22:56:06]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Fady Samuel, 2016-09-30 23:05:59]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 23:06:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-30 23:10:43]

https://codereview.chromium.org/2382873002/diff/240001/content/browser/render...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/2382873002/diff/240001/content/browser/render...
content/browser/renderer_host/compositor_impl_android.cc:333: bool
BindToClient(cc::OutputFrameSink* client) override {
On 2016/09/30 21:49:30, Fady Samuel wrote:
> On 2016/09/30 21:06:06, boliu wrote:
> > does this compile? this is still an OutputSurface, not FrameSink?
> 
> Done.

We don't actually build with ENABLE_VULKAN anywhere atm, but it's nice to try
keep this code not insanely wrong I guess.

[jam, 2016-09-30 23:26:05]

lgtm

[commit-bot: I haz the power, 2016-09-30 23:59:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 23:59:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Fady Samuel, 2016-10-01 00:04:31]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-01 00:04:32]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
tsepez@chromium.org, sky@chromium.org, dtrainor@chromium.org,
reveman@chromium.org, boliu@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2382873002/#ps340001
(title: "Fix surface_unittest on Windows")

[commit-bot: I haz the power, 2016-10-01 00:05:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 00:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 00:18:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-10-01 01:12:02]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-01 01:12:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, reveman@chromium.org, sky@chromium.org, jam@chromium.org,
boliu@chromium.org, enne@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2382873002/#ps360001
(title: "Fix SurfaceSequence hash on Windows")

[commit-bot: I haz the power, 2016-10-01 01:12:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 01:41:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 01:41:53]

Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)

[Fady Samuel, 2016-10-01 02:12:44]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-01 02:12:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, reveman@chromium.org, sky@chromium.org, jam@chromium.org,
boliu@chromium.org, enne@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2382873002/#ps380001
(title: "Add missing include in frame_sink_id.h")

[commit-bot: I haz the power, 2016-10-01 02:13:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 04:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 04:04:55]

Failed to apply patch for
third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp:48
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp' with
conflicts.
  U third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

Patch:      
third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp
Index: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp
diff --git
a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp
b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp
index
60f2cdbf7bcbe8c8f32ea0d7cdcc0bcf482435f9..e33b246fecd133b4b4be696d49b590e01c46d153
100644
--- a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp
+++ b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp
@@ -48,7 +48,8 @@ OffscreenCanvas*
HTMLCanvasElementModule::transferControlToOffscreenInternal(HTM
     if (bridge) {
         // If a bridge exists, it means canvas.createSurfaceLayer() has been
called
         // and its SurfaceId has been populated as well.
-        offscreenCanvas->setSurfaceId(bridge->getSurfaceId().client_id(),
bridge->getSurfaceId().local_id(), bridge->getSurfaceId().nonce());
+        // TODO(fsamuel): Plumb FrameSinkId into blink.
+       
offscreenCanvas->setSurfaceId(bridge->getSurfaceId().frame_sink_id().client_id(),
bridge->getSurfaceId().local_id(), bridge->getSurfaceId().nonce());
     }
     return offscreenCanvas;
 }

[Fady Samuel, 2016-10-01 12:42:52]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-01 12:42:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, reveman@chromium.org, sky@chromium.org, jam@chromium.org,
boliu@chromium.org, enne@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2382873002/#ps400001
(title: "Rebased")

[commit-bot: I haz the power, 2016-10-01 12:43:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 14:07:37]

Description was changed from

==========
Replace usage of SurfaceId's client_id with FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts and so 
FrameSinkObservers can be registered in any order 
(subsequent CL).

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replace usage of SurfaceId's client_id with FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts and so 
FrameSinkObservers can be registered in any order 
(subsequent CL).

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-01 14:07:40]

Committed patchset #21 (id:400001)

[commit-bot: I haz the power, 2016-10-01 14:09:06]

Description was changed from

==========
Replace usage of SurfaceId's client_id with FrameSinkId

This CL mechanically replaces SurfaceClientId with a 
FrameSinkId that consists of two components. The second 
component is left empty in this CL. In a subsequent CL, 
FrameSinkId will be made into a (RenderProcessHost ID, 
RoutingID) pair and 
GpuProcessTransportFactory::AllocateFrameSinkId will go 
away. In Mus+Ash, the FrameSinkId will be the WindowId in 
that subsequent CL.

This will allow the display compositor to route new surface 
IDs allocated in clients to the appropriate endpoints in 
the display compositor host (browser or window server). 
Also, these IDs persist across display compositor restarts and so 
FrameSinkObservers can be registered in any order 
(subsequent CL).

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replace usage of SurfaceId's client_id with FrameSinkId

This CL mechanically replaces SurfaceClientId with a
FrameSinkId that consists of two components. The second
component is left empty in this CL. In a subsequent CL,
FrameSinkId will be made into a (RenderProcessHost ID,
RoutingID) pair and
GpuProcessTransportFactory::AllocateFrameSinkId will go
away. In Mus+Ash, the FrameSinkId will be the WindowId in
that subsequent CL.

This will allow the display compositor to route new surface
IDs allocated in clients to the appropriate endpoints in
the display compositor host (browser or window server).
Also, these IDs persist across display compositor restarts and so
FrameSinkObservers can be registered in any order
(subsequent CL).

BUG=647852

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/e0f705bd4f61d868a0dcb7a7f1a905b3033ede84
Cr-Commit-Position: refs/heads/master@{#422314}
==========

[commit-bot: I haz the power, 2016-10-01 14:09:09]

Patchset 21 (id:??) landed as
https://crrev.com/e0f705bd4f61d868a0dcb7a7f1a905b3033ede84
Cr-Commit-Position: refs/heads/master@{#422314}