Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: cc/surfaces/surfaces_pixeltest.cc

Issue 2382873002: Replace usage of SurfaceId's client_id with FrameSinkId (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/surface_unittest.cc ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/compositor_frame.h" 5 #include "cc/output/compositor_frame.h"
6 #include "cc/quads/render_pass.h" 6 #include "cc/quads/render_pass.h"
7 #include "cc/quads/solid_color_draw_quad.h" 7 #include "cc/quads/solid_color_draw_quad.h"
8 #include "cc/quads/surface_draw_quad.h" 8 #include "cc/quads/surface_draw_quad.h"
9 #include "cc/surfaces/surface.h" 9 #include "cc/surfaces/surface.h"
10 #include "cc/surfaces/surface_aggregator.h" 10 #include "cc/surfaces/surface_aggregator.h"
11 #include "cc/surfaces/surface_factory.h" 11 #include "cc/surfaces/surface_factory.h"
12 #include "cc/surfaces/surface_factory_client.h" 12 #include "cc/surfaces/surface_factory_client.h"
13 #include "cc/surfaces/surface_id_allocator.h" 13 #include "cc/surfaces/surface_id_allocator.h"
14 #include "cc/surfaces/surface_manager.h" 14 #include "cc/surfaces/surface_manager.h"
15 #include "cc/test/pixel_comparator.h" 15 #include "cc/test/pixel_comparator.h"
16 #include "cc/test/pixel_test.h" 16 #include "cc/test/pixel_test.h"
17 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
18 18
19 #if !defined(OS_ANDROID) 19 #if !defined(OS_ANDROID)
20 20
21 namespace cc { 21 namespace cc {
22 namespace { 22 namespace {
23 23
24 static constexpr uint32_t kArbitraryClientId = 1u; 24 static constexpr FrameSinkId kArbitraryFrameSinkId(1, 1);
25 25
26 class EmptySurfaceFactoryClient : public SurfaceFactoryClient { 26 class EmptySurfaceFactoryClient : public SurfaceFactoryClient {
27 public: 27 public:
28 void ReturnResources(const ReturnedResourceArray& resources) override {} 28 void ReturnResources(const ReturnedResourceArray& resources) override {}
29 void SetBeginFrameSource(BeginFrameSource* begin_frame_source) override {} 29 void SetBeginFrameSource(BeginFrameSource* begin_frame_source) override {}
30 }; 30 };
31 31
32 class SurfacesPixelTest : public RendererPixelTest<GLRenderer> { 32 class SurfacesPixelTest : public RendererPixelTest<GLRenderer> {
33 public: 33 public:
34 SurfacesPixelTest() 34 SurfacesPixelTest()
35 : allocator_(kArbitraryClientId), factory_(&manager_, &client_) {} 35 : allocator_(kArbitraryFrameSinkId), factory_(&manager_, &client_) {}
36 36
37 protected: 37 protected:
38 SurfaceManager manager_; 38 SurfaceManager manager_;
39 SurfaceIdAllocator allocator_; 39 SurfaceIdAllocator allocator_;
40 EmptySurfaceFactoryClient client_; 40 EmptySurfaceFactoryClient client_;
41 SurfaceFactory factory_; 41 SurfaceFactory factory_;
42 }; 42 };
43 43
44 SharedQuadState* CreateAndAppendTestSharedQuadState( 44 SharedQuadState* CreateAndAppendTestSharedQuadState(
45 RenderPass* render_pass, 45 RenderPass* render_pass,
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 332
333 factory_.Destroy(root_surface_id); 333 factory_.Destroy(root_surface_id);
334 factory_.Destroy(left_child_id); 334 factory_.Destroy(left_child_id);
335 factory_.Destroy(right_child_id); 335 factory_.Destroy(right_child_id);
336 } 336 }
337 337
338 } // namespace 338 } // namespace
339 } // namespace cc 339 } // namespace cc
340 340
341 #endif // !defined(OS_ANDROID) 341 #endif // !defined(OS_ANDROID)
OLDNEW
« no previous file with comments | « cc/surfaces/surface_unittest.cc ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698