Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: cc/surfaces/surface_unittest.cc

Issue 2382873002: Replace usage of SurfaceId's client_id with FrameSinkId (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/surface_sequence.h ('k') | cc/surfaces/surfaces_pixeltest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/surfaces/surface.h" 5 #include "cc/surfaces/surface.h"
6 #include "cc/surfaces/surface_factory.h" 6 #include "cc/surfaces/surface_factory.h"
7 #include "cc/surfaces/surface_factory_client.h" 7 #include "cc/surfaces/surface_factory_client.h"
8 #include "cc/surfaces/surface_id_allocator.h" 8 #include "cc/surfaces/surface_id_allocator.h"
9 #include "cc/surfaces/surface_manager.h" 9 #include "cc/surfaces/surface_manager.h"
10 #include "cc/test/scheduler_test_common.h" 10 #include "cc/test/scheduler_test_common.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 #include "ui/gfx/geometry/size.h" 12 #include "ui/gfx/geometry/size.h"
13 13
14 namespace cc { 14 namespace cc {
15 namespace { 15 namespace {
16 16
17 static constexpr uint32_t kArbitraryClientId = 0; 17 static constexpr FrameSinkId kArbitraryFrameSinkId(1, 1);
18 18
19 class FakeSurfaceFactoryClient : public SurfaceFactoryClient { 19 class FakeSurfaceFactoryClient : public SurfaceFactoryClient {
20 public: 20 public:
21 FakeSurfaceFactoryClient() : begin_frame_source_(nullptr) {} 21 FakeSurfaceFactoryClient() : begin_frame_source_(nullptr) {}
22 22
23 void ReturnResources(const ReturnedResourceArray& resources) override {} 23 void ReturnResources(const ReturnedResourceArray& resources) override {}
24 24
25 void SetBeginFrameSource(BeginFrameSource* begin_frame_source) override { 25 void SetBeginFrameSource(BeginFrameSource* begin_frame_source) override {
26 begin_frame_source_ = begin_frame_source; 26 begin_frame_source_ = begin_frame_source;
27 } 27 }
28 28
29 BeginFrameSource* begin_frame_source() { return begin_frame_source_; } 29 BeginFrameSource* begin_frame_source() { return begin_frame_source_; }
30 30
31 private: 31 private:
32 BeginFrameSource* begin_frame_source_; 32 BeginFrameSource* begin_frame_source_;
33 }; 33 };
34 34
35 TEST(SurfaceTest, SurfaceLifetime) { 35 TEST(SurfaceTest, SurfaceLifetime) {
36 SurfaceManager manager; 36 SurfaceManager manager;
37 FakeSurfaceFactoryClient surface_factory_client; 37 FakeSurfaceFactoryClient surface_factory_client;
38 SurfaceFactory factory(&manager, &surface_factory_client); 38 SurfaceFactory factory(&manager, &surface_factory_client);
39 39
40 SurfaceId surface_id(kArbitraryClientId, 6, 0); 40 SurfaceId surface_id(kArbitraryFrameSinkId, 6, 0);
41 { 41 {
42 factory.Create(surface_id); 42 factory.Create(surface_id);
43 EXPECT_TRUE(manager.GetSurfaceForId(surface_id)); 43 EXPECT_TRUE(manager.GetSurfaceForId(surface_id));
44 factory.Destroy(surface_id); 44 factory.Destroy(surface_id);
45 } 45 }
46 46
47 EXPECT_EQ(NULL, manager.GetSurfaceForId(surface_id)); 47 EXPECT_EQ(NULL, manager.GetSurfaceForId(surface_id));
48 } 48 }
49 49
50 TEST(SurfaceTest, SurfaceIds) { 50 TEST(SurfaceTest, SurfaceIds) {
51 uint32_t client_ids[] = {0u, 37u, ~0u}; 51 FrameSinkId frame_sink_ids[] = {FrameSinkId(0, 0), FrameSinkId(37, 37),
52 FrameSinkId(1337, 1234)};
52 for (size_t i = 0; i < 3; ++i) { 53 for (size_t i = 0; i < 3; ++i) {
53 uint32_t client_id = client_ids[i]; 54 const FrameSinkId& frame_sink_id = frame_sink_ids[i];
54 SurfaceIdAllocator allocator(client_id); 55 SurfaceIdAllocator allocator(frame_sink_id);
55 SurfaceId id1 = allocator.GenerateId(); 56 SurfaceId id1 = allocator.GenerateId();
56 EXPECT_EQ(id1.client_id(), client_id); 57 EXPECT_EQ(id1.frame_sink_id(), frame_sink_id);
57 SurfaceId id2 = allocator.GenerateId(); 58 SurfaceId id2 = allocator.GenerateId();
58 EXPECT_EQ(id2.client_id(), client_id); 59 EXPECT_EQ(id2.frame_sink_id(), frame_sink_id);
59 EXPECT_NE(id1.local_id(), id2.local_id()); 60 EXPECT_NE(id1.local_id(), id2.local_id());
60 EXPECT_NE(id1.nonce(), id2.nonce()); 61 EXPECT_NE(id1.nonce(), id2.nonce());
61 } 62 }
62 } 63 }
63 64
64 } // namespace 65 } // namespace
65 } // namespace cc 66 } // namespace cc
OLDNEW
« no previous file with comments | « cc/surfaces/surface_sequence.h ('k') | cc/surfaces/surfaces_pixeltest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698