Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: cc/ipc/struct_traits_unittest.cc

Issue 2382873002: Replace usage of SurfaceId's client_id with FrameSinkId (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/ipc/frame_sink_id_struct_traits.h ('k') | cc/ipc/surface_id.mojom » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_loop.h" 5 #include "base/message_loop/message_loop.h"
6 #include "cc/input/selection.h" 6 #include "cc/input/selection.h"
7 #include "cc/ipc/traits_test_service.mojom.h" 7 #include "cc/ipc/traits_test_service.mojom.h"
8 #include "cc/quads/debug_border_draw_quad.h" 8 #include "cc/quads/debug_border_draw_quad.h"
9 #include "cc/quads/render_pass.h" 9 #include "cc/quads/render_pass.h"
10 #include "cc/quads/render_pass_draw_quad.h" 10 #include "cc/quads/render_pass_draw_quad.h"
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 selection.end.set_visible(false); 279 selection.end.set_visible(false);
280 selection.end.set_type(gfx::SelectionBound::RIGHT); 280 selection.end.set_type(gfx::SelectionBound::RIGHT);
281 selection.is_editable = true; 281 selection.is_editable = true;
282 selection.is_empty_text_form_control = true; 282 selection.is_empty_text_form_control = true;
283 ui::LatencyInfo latency_info; 283 ui::LatencyInfo latency_info;
284 latency_info.AddLatencyNumber( 284 latency_info.AddLatencyNumber(
285 ui::LATENCY_BEGIN_SCROLL_LISTENER_UPDATE_MAIN_COMPONENT, 1337, 7331); 285 ui::LATENCY_BEGIN_SCROLL_LISTENER_UPDATE_MAIN_COMPONENT, 1337, 7331);
286 std::vector<ui::LatencyInfo> latency_infos = {latency_info}; 286 std::vector<ui::LatencyInfo> latency_infos = {latency_info};
287 std::vector<uint32_t> satisfies_sequences = {1234, 1337}; 287 std::vector<uint32_t> satisfies_sequences = {1234, 1337};
288 std::vector<SurfaceId> referenced_surfaces; 288 std::vector<SurfaceId> referenced_surfaces;
289 SurfaceId id(1234, 5678, 9101112); 289 SurfaceId id(FrameSinkId(1234, 4321), 5678, 9101112);
290 referenced_surfaces.push_back(id); 290 referenced_surfaces.push_back(id);
291 291
292 CompositorFrameMetadata input; 292 CompositorFrameMetadata input;
293 input.device_scale_factor = device_scale_factor; 293 input.device_scale_factor = device_scale_factor;
294 input.root_scroll_offset = root_scroll_offset; 294 input.root_scroll_offset = root_scroll_offset;
295 input.page_scale_factor = page_scale_factor; 295 input.page_scale_factor = page_scale_factor;
296 input.scrollable_viewport_size = scrollable_viewport_size; 296 input.scrollable_viewport_size = scrollable_viewport_size;
297 input.root_layer_size = root_layer_size; 297 input.root_layer_size = root_layer_size;
298 input.min_page_scale_factor = min_page_scale_factor; 298 input.min_page_scale_factor = min_page_scale_factor;
299 input.max_page_scale_factor = max_page_scale_factor; 299 input.max_page_scale_factor = max_page_scale_factor;
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 debug_quad->SetNew(sqs, rect1, rect1, color1, width1); 431 debug_quad->SetNew(sqs, rect1, rect1, color1, width1);
432 432
433 const gfx::Rect rect2(2468, 8642, 4321, 1234); 433 const gfx::Rect rect2(2468, 8642, 4321, 1234);
434 const uint32_t color2 = 0xffffffff; 434 const uint32_t color2 = 0xffffffff;
435 const bool force_anti_aliasing_off = true; 435 const bool force_anti_aliasing_off = true;
436 SolidColorDrawQuad* solid_quad = 436 SolidColorDrawQuad* solid_quad =
437 render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); 437 render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
438 solid_quad->SetNew(sqs, rect2, rect2, color2, force_anti_aliasing_off); 438 solid_quad->SetNew(sqs, rect2, rect2, color2, force_anti_aliasing_off);
439 439
440 const gfx::Rect rect3(1029, 3847, 5610, 2938); 440 const gfx::Rect rect3(1029, 3847, 5610, 2938);
441 const SurfaceId surface_id(1234, 5678, 2468); 441 const SurfaceId surface_id(FrameSinkId(1234, 4321), 5678, 2468);
442 SurfaceDrawQuad* surface_quad = 442 SurfaceDrawQuad* surface_quad =
443 render_pass->CreateAndAppendDrawQuad<SurfaceDrawQuad>(); 443 render_pass->CreateAndAppendDrawQuad<SurfaceDrawQuad>();
444 surface_quad->SetNew(sqs, rect3, rect3, surface_id); 444 surface_quad->SetNew(sqs, rect3, rect3, surface_id);
445 445
446 const gfx::Rect rect4(1234, 5678, 9101112, 13141516); 446 const gfx::Rect rect4(1234, 5678, 9101112, 13141516);
447 const ResourceId resource_id4(1337); 447 const ResourceId resource_id4(1337);
448 const RenderPassId render_pass_id(1234, 5678); 448 const RenderPassId render_pass_id(1234, 5678);
449 const gfx::Vector2dF mask_uv_scale(1337.1f, 1234.2f); 449 const gfx::Vector2dF mask_uv_scale(1337.1f, 1234.2f);
450 const gfx::Size mask_texture_size(1234, 5678); 450 const gfx::Size mask_texture_size(1234, 5678);
451 FilterOperations filters; 451 FilterOperations filters;
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 SolidColorDrawQuad* color_quad = 603 SolidColorDrawQuad* color_quad =
604 input->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); 604 input->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
605 const gfx::Rect color_quad_rect(123, 456, 789, 101); 605 const gfx::Rect color_quad_rect(123, 456, 789, 101);
606 color_quad->SetNew(shared_state_2, color_quad_rect, color_quad_rect, 606 color_quad->SetNew(shared_state_2, color_quad_rect, color_quad_rect,
607 SK_ColorRED, true); 607 SK_ColorRED, true);
608 608
609 SurfaceDrawQuad* surface_quad = 609 SurfaceDrawQuad* surface_quad =
610 input->CreateAndAppendDrawQuad<SurfaceDrawQuad>(); 610 input->CreateAndAppendDrawQuad<SurfaceDrawQuad>();
611 const gfx::Rect surface_quad_rect(1337, 2448, 1234, 5678); 611 const gfx::Rect surface_quad_rect(1337, 2448, 1234, 5678);
612 surface_quad->SetNew(shared_state_2, surface_quad_rect, surface_quad_rect, 612 surface_quad->SetNew(shared_state_2, surface_quad_rect, surface_quad_rect,
613 SurfaceId(1337, 1234, 2468)); 613 SurfaceId(FrameSinkId(1337, 1234), 1234, 2468));
614 614
615 std::unique_ptr<RenderPass> output; 615 std::unique_ptr<RenderPass> output;
616 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy(); 616 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
617 proxy->EchoRenderPass(input->DeepCopy(), &output); 617 proxy->EchoRenderPass(input->DeepCopy(), &output);
618 618
619 EXPECT_EQ(input->quad_list.size(), output->quad_list.size()); 619 EXPECT_EQ(input->quad_list.size(), output->quad_list.size());
620 EXPECT_EQ(input->shared_quad_state_list.size(), 620 EXPECT_EQ(input->shared_quad_state_list.size(),
621 output->shared_quad_state_list.size()); 621 output->shared_quad_state_list.size());
622 EXPECT_EQ(id, output->id); 622 EXPECT_EQ(id, output->id);
623 EXPECT_EQ(output_rect, output->output_rect); 623 EXPECT_EQ(output_rect, output->output_rect);
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy(); 757 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
758 Selection<gfx::SelectionBound> output; 758 Selection<gfx::SelectionBound> output;
759 proxy->EchoSelection(input, &output); 759 proxy->EchoSelection(input, &output);
760 EXPECT_EQ(start, output.start); 760 EXPECT_EQ(start, output.start);
761 EXPECT_EQ(end, output.end); 761 EXPECT_EQ(end, output.end);
762 EXPECT_EQ(is_editable, output.is_editable); 762 EXPECT_EQ(is_editable, output.is_editable);
763 EXPECT_EQ(is_empty_text_form_control, output.is_empty_text_form_control); 763 EXPECT_EQ(is_empty_text_form_control, output.is_empty_text_form_control);
764 } 764 }
765 765
766 TEST_F(StructTraitsTest, SurfaceId) { 766 TEST_F(StructTraitsTest, SurfaceId) {
767 const uint32_t client_id = 1337; 767 static constexpr FrameSinkId frame_sink_id(1337, 1234);
768 const uint32_t local_id = 0xfbadbeef; 768 const uint32_t local_id = 0xfbadbeef;
769 const uint64_t nonce = 0xdeadbeef; 769 const uint64_t nonce = 0xdeadbeef;
770 SurfaceId input(client_id, local_id, nonce); 770 SurfaceId input(frame_sink_id, local_id, nonce);
771 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy(); 771 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
772 SurfaceId output; 772 SurfaceId output;
773 proxy->EchoSurfaceId(input, &output); 773 proxy->EchoSurfaceId(input, &output);
774 EXPECT_EQ(client_id, output.client_id()); 774 EXPECT_EQ(frame_sink_id, output.frame_sink_id());
775 EXPECT_EQ(local_id, output.local_id()); 775 EXPECT_EQ(local_id, output.local_id());
776 EXPECT_EQ(nonce, output.nonce()); 776 EXPECT_EQ(nonce, output.nonce());
777 } 777 }
778 778
779 TEST_F(StructTraitsTest, SurfaceSequence) { 779 TEST_F(StructTraitsTest, SurfaceSequence) {
780 const uint32_t client_id = 2016; 780 const FrameSinkId frame_sink_id(2016, 1234);
781 const uint32_t sequence = 0xfbadbeef; 781 const uint32_t sequence = 0xfbadbeef;
782 SurfaceSequence input(client_id, sequence); 782 SurfaceSequence input(frame_sink_id, sequence);
783 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy(); 783 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
784 SurfaceSequence output; 784 SurfaceSequence output;
785 proxy->EchoSurfaceSequence(input, &output); 785 proxy->EchoSurfaceSequence(input, &output);
786 EXPECT_EQ(client_id, output.client_id); 786 EXPECT_EQ(frame_sink_id, output.frame_sink_id);
787 EXPECT_EQ(sequence, output.sequence); 787 EXPECT_EQ(sequence, output.sequence);
788 } 788 }
789 789
790 TEST_F(StructTraitsTest, SharedQuadState) { 790 TEST_F(StructTraitsTest, SharedQuadState) {
791 const gfx::Transform quad_to_target_transform(1.f, 2.f, 3.f, 4.f, 5.f, 6.f, 791 const gfx::Transform quad_to_target_transform(1.f, 2.f, 3.f, 4.f, 5.f, 6.f,
792 7.f, 8.f, 9.f, 10.f, 11.f, 12.f, 792 7.f, 8.f, 9.f, 10.f, 11.f, 12.f,
793 13.f, 14.f, 15.f, 16.f); 793 13.f, 14.f, 15.f, 16.f);
794 const gfx::Size layer_bounds(1234, 5678); 794 const gfx::Size layer_bounds(1234, 5678);
795 const gfx::Rect visible_layer_rect(12, 34, 56, 78); 795 const gfx::Rect visible_layer_rect(12, 34, 56, 78);
796 const gfx::Rect clip_rect(123, 456, 789, 101112); 796 const gfx::Rect clip_rect(123, 456, 789, 101112);
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
919 EXPECT_EQ(u_plane_resource_id, out_quad->u_plane_resource_id()); 919 EXPECT_EQ(u_plane_resource_id, out_quad->u_plane_resource_id());
920 EXPECT_EQ(v_plane_resource_id, out_quad->v_plane_resource_id()); 920 EXPECT_EQ(v_plane_resource_id, out_quad->v_plane_resource_id());
921 EXPECT_EQ(a_plane_resource_id, out_quad->a_plane_resource_id()); 921 EXPECT_EQ(a_plane_resource_id, out_quad->a_plane_resource_id());
922 EXPECT_EQ(color_space, out_quad->color_space); 922 EXPECT_EQ(color_space, out_quad->color_space);
923 EXPECT_EQ(resource_offset, out_quad->resource_offset); 923 EXPECT_EQ(resource_offset, out_quad->resource_offset);
924 EXPECT_EQ(resource_multiplier, out_quad->resource_multiplier); 924 EXPECT_EQ(resource_multiplier, out_quad->resource_multiplier);
925 EXPECT_EQ(bits_per_channel, out_quad->bits_per_channel); 925 EXPECT_EQ(bits_per_channel, out_quad->bits_per_channel);
926 } 926 }
927 927
928 } // namespace cc 928 } // namespace cc
OLDNEW
« no previous file with comments | « cc/ipc/frame_sink_id_struct_traits.h ('k') | cc/ipc/surface_id.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698