Move PasswordForm from //content to //autofill.

Move PasswordForm from //content to //autofill.

The primary goal of this change is to allow PasswordForm to depend on //
autofill code for password generation. A side benefit is that this change will
allow iOS to cleanly use PasswordForm.

To accommodate the fact that multiple message files need to know about PasswordForm, it is put into a newly-created autofill_param_traits_macros.h rather than autofill_messages.h.

BUG=263121
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221991

[blundell, 2013-09-05 12:12:56]

Hi John and Ilya,

Could you do the initial reviews on this CL focusing on //content and
//components/autofill? In particular, please be sure to look closely at the
changes I made around IPC.

Thanks,

Colin

[jam, 2013-09-05 16:07:15]

https://codereview.chromium.org/23742004/diff/27001/components/autofill/core/...
File components/autofill/core/common/autofill_param_traits_macros.h (right):

https://codereview.chromium.org/23742004/diff/27001/components/autofill/core/...
components/autofill/core/common/autofill_param_traits_macros.h:2: // Use of this
source code is governed by a BSD-style license that can be
a macros.h file is done to share serialization traits with multiple .messages
file. so just move the ones here that are used by one messages files, but the
ones that aren't keep in the autofill_messages.h

https://codereview.chromium.org/23742004/diff/27001/components/autofill/core/...
components/autofill/core/common/autofill_param_traits_macros.h:84:
IPC_STRUCT_TRAITS_MEMBER(signon_realm)
nit: need indentation

[blundell, 2013-09-05 16:33:56]

Thanks.

https://codereview.chromium.org/23742004/diff/27001/components/autofill/core/...
File components/autofill/core/common/autofill_param_traits_macros.h (right):

https://codereview.chromium.org/23742004/diff/27001/components/autofill/core/...
components/autofill/core/common/autofill_param_traits_macros.h:2: // Use of this
source code is governed by a BSD-style license that can be
On 2013/09/05 16:07:16, jam wrote:
> a macros.h file is done to share serialization traits with multiple .messages
> file. so just move the ones here that are used by one messages files, but the
> ones that aren't keep in the autofill_messages.h

Done.

https://codereview.chromium.org/23742004/diff/27001/components/autofill/core/...
components/autofill/core/common/autofill_param_traits_macros.h:84:
IPC_STRUCT_TRAITS_MEMBER(signon_realm)
On 2013/09/05 16:07:16, jam wrote:
> nit: need indentation

Done.

[jam, 2013-09-05 22:44:21]

lgtm (I mostly reviewed the moved code, not all the reset). let me know if you
want a more detailed review

[Ilya Sherman, 2013-09-05 22:53:34]

LGTM

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
File components/autofill/content/renderer/password_form_conversion_utils.h
(right):

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
components/autofill/content/renderer/password_form_conversion_utils.h:22:
scoped_ptr<autofill::PasswordForm> CreatePasswordForm(
nit: No need for namespace.

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
File components/autofill/content/renderer/password_generation_manager.cc
(right):

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
components/autofill/content/renderer/password_generation_manager.cc:111:
scoped_ptr<autofill::PasswordForm> password_form(
nit: No need for namespace.

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
File components/autofill/content/renderer/password_generation_manager.h (right):

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
components/autofill/content/renderer/password_generation_manager.h:52: void
OnFormNotBlacklisted(const autofill::PasswordForm& form);
nit: No need for namespace.

[blundell, 2013-09-06 08:36:24]

Thanks.

Nico, can you take a look over chrome/? It'll be more fun than a barrel of
monkeys!

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
File components/autofill/content/renderer/password_form_conversion_utils.h
(right):

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
components/autofill/content/renderer/password_form_conversion_utils.h:22:
scoped_ptr<autofill::PasswordForm> CreatePasswordForm(
On 2013/09/05 22:53:35, Ilya Sherman wrote:
> nit: No need for namespace.

Done.

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
File components/autofill/content/renderer/password_generation_manager.cc
(right):

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
components/autofill/content/renderer/password_generation_manager.cc:111:
scoped_ptr<autofill::PasswordForm> password_form(
On 2013/09/05 22:53:35, Ilya Sherman wrote:
> nit: No need for namespace.

Done.

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
File components/autofill/content/renderer/password_generation_manager.h (right):

https://codereview.chromium.org/23742004/diff/41001/components/autofill/conte...
components/autofill/content/renderer/password_generation_manager.h:52: void
OnFormNotBlacklisted(const autofill::PasswordForm& form);
On 2013/09/05 22:53:35, Ilya Sherman wrote:
> nit: No need for namespace.

Done.

[blundell, 2013-09-06 11:05:41]

jschuh: //components/autofill/core/common/autofill_messages.h,
//chrome/common/importer/profile_import_process_messages.h

[jschuh, 2013-09-06 13:13:30]

ipc security rubberstamp lgtm. file and namespace moves.

[Nico, 2013-09-07 00:13:28]

chrome/ lgtm

Sorry about the delay!

[commit-bot: I haz the power, 2013-09-09 07:01:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/23742004/64001

[commit-bot: I haz the power, 2013-09-09 08:01:57]

Change committed as 221991