chrome/browser/password_manager/password_form_manager.cc - Issue 23742004: Move PasswordForm from //content to //autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_form_manager.cc

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils

Patch Set: Rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_form_manager.h ('k') | chrome/browser/password_manager/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_form_manager.cc

diff --git a/chrome/browser/password_manager/password_form_manager.cc b/chrome/browser/password_manager/password_form_manager.cc

index 59c5a6a2e16fcf646892747a4edb4440b8930f07..6c2062557338d5425246f695e01f7c2b4a3cab8b 100644

--- a/chrome/browser/password_manager/password_form_manager.cc

+++ b/chrome/browser/password_manager/password_form_manager.cc

@@ -15,13 +15,13 @@

#include "chrome/browser/profiles/profile.h"

#include "components/autofill/core/browser/validation.h"

#include "components/autofill/core/common/autofill_messages.h"

+#include "components/autofill/core/common/password_form.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

-#include "content/public/common/password_form.h"

+using autofill::PasswordForm;

+using autofill::PasswordFormMap;

using base::Time;

-using content::PasswordForm;

-using content::PasswordFormMap;

PasswordFormManager::PasswordFormManager(Profile* profile,

PasswordManager* password_manager,

@@ -362,13 +362,13 @@ void PasswordFormManager::OnRequestDone(

void PasswordFormManager::OnPasswordStoreRequestDone(

CancelableRequestProvider::Handle handle,

- const std::vector<content::PasswordForm*>& result) {

+ const std::vector<autofill::PasswordForm*>& result) {

// TODO(kaiwang): Remove this function.

NOTREACHED();

}

void PasswordFormManager::OnGetPasswordStoreResults(

- const std::vector<content::PasswordForm*>& results) {

+ const std::vector<autofill::PasswordForm*>& results) {

DCHECK_EQ(state_, MATCHING_PHASE);

if (results.empty()) {