chrome/browser/importer/firefox_importer_browsertest.cc - Issue 23742004: Move PasswordForm from //content to //autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/firefox_importer_browsertest.cc

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils

Patch Set: Rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/importer/external_process_importer_client.cc ('k') | chrome/browser/importer/ie_importer_browsertest_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/firefox_importer_browsertest.cc

diff --git a/chrome/browser/importer/firefox_importer_browsertest.cc b/chrome/browser/importer/firefox_importer_browsertest.cc

index 8082e7665af3e255c9163cf41ab72ee394a77e60..83f9eba88b173ef2fb9e586055b51dc8b7162c68 100644

--- a/chrome/browser/importer/firefox_importer_browsertest.cc

+++ b/chrome/browser/importer/firefox_importer_browsertest.cc

@@ -21,7 +21,7 @@

#include "chrome/common/importer/imported_favicon_usage.h"

#include "chrome/common/importer/importer_data_types.h"

#include "chrome/test/base/in_process_browser_test.h"

-#include "content/public/common/password_form.h"

+#include "components/autofill/core/common/password_form.h"

#include "testing/gtest/include/gtest/gtest.h"

// TODO(estade): some of these are disabled on mac. http://crbug.com/48007

@@ -132,7 +132,7 @@ class FirefoxObserver : public ProfileWriter,

return true;

}

- virtual void AddPasswordForm(const content::PasswordForm& form) OVERRIDE {

+ virtual void AddPasswordForm(const autofill::PasswordForm& form) OVERRIDE {

PasswordInfo p = kFirefoxPasswords[password_count_];

EXPECT_EQ(p.origin, form.origin.spec());

EXPECT_EQ(p.realm, form.signon_realm);