chrome/browser/password_manager/password_manager.cc - Issue 23742004: Move PasswordForm from //content to //autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils

Patch Set: Rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager.h ('k') | chrome/browser/password_manager/password_manager_delegate_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager.cc

diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc

index f6834accce6c7044010c70b161ca070203b026db..efa51ff1d7259d3ea6de727a51ab16c4da97fa0f 100644

--- a/chrome/browser/password_manager/password_manager.cc

+++ b/chrome/browser/password_manager/password_manager.cc

@@ -26,10 +26,10 @@

#include "content/public/common/frame_navigate_params.h"

#include "grit/generated_resources.h"

+using autofill::PasswordForm;

+using autofill::PasswordFormMap;

using content::UserMetricsAction;

using content::WebContents;

-using content::PasswordForm;

-using content::PasswordFormMap;

DEFINE_WEB_CONTENTS_USER_DATA_KEY(PasswordManager);

@@ -358,7 +358,7 @@ void PasswordManager::PossiblyInitializeUsernamesExperiment(

return;

bool other_possible_usernames_exist = false;

- for (content::PasswordFormMap::const_iterator it = best_matches.begin();

+ for (autofill::PasswordFormMap::const_iterator it = best_matches.begin();

it != best_matches.end(); ++it) {

if (!it->second->other_possible_usernames.empty()) {

other_possible_usernames_exist = true;