components/autofill/content/renderer/password_autofill_agent.cc - Issue 23742004: Move PasswordForm from //content to //autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils

Patch Set: Rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.h ('k') | components/autofill/content/renderer/password_form_conversion_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index bc92faa95fe60bb8073c4e554727a4c985a82128..d9a12cd7efd93e97f0acb8e9c3ef11061e4cc441 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -13,8 +13,8 @@

#include "components/autofill/content/renderer/password_form_conversion_utils.h"

#include "components/autofill/core/common/autofill_messages.h"

#include "components/autofill/core/common/form_field_data.h"

+#include "components/autofill/core/common/password_form.h"

#include "components/autofill/core/common/password_form_fill_data.h"

-#include "content/public/common/password_form.h"

#include "content/public/renderer/render_view.h"

#include "third_party/WebKit/public/platform/WebVector.h"

#include "third_party/WebKit/public/web/WebAutofillClient.h"

@@ -364,7 +364,7 @@ void PasswordAutofillAgent::SendPasswordForms(WebKit::WebFrame* frame,

WebKit::WebVector<WebKit::WebFormElement> forms;

frame->document().forms(forms);

- std::vector<content::PasswordForm> password_forms;

+ std::vector<PasswordForm> password_forms;

for (size_t i = 0; i < forms.size(); ++i) {

const WebKit::WebFormElement& form = forms[i];

@@ -373,7 +373,7 @@ void PasswordAutofillAgent::SendPasswordForms(WebKit::WebFrame* frame,

if (only_visible && !IsWebNodeVisible(form))

continue;

- scoped_ptr<content::PasswordForm> password_form(CreatePasswordForm(form));

+ scoped_ptr<PasswordForm> password_form(CreatePasswordForm(form));

if (password_form.get())

password_forms.push_back(*password_form);

}

@@ -445,7 +445,7 @@ void PasswordAutofillAgent::WillSendSubmitEvent(

void PasswordAutofillAgent::WillSubmitForm(WebKit::WebFrame* frame,

const WebKit::WebFormElement& form) {

- scoped_ptr<content::PasswordForm> submitted_form = CreatePasswordForm(form);

+ scoped_ptr<PasswordForm> submitted_form = CreatePasswordForm(form);

// If there is a provisionally saved password, copy over the previous

// password value so we get the user's typed password, not the value that