chrome/browser/password_manager/password_store_win.cc - Issue 23742004: Move PasswordForm from //content to //autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_win.cc

Issue 23742004: Move PasswordForm from //content to //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_password_form_conversion_utils

Patch Set: Rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_win.h ('k') | chrome/browser/password_manager/password_store_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_win.cc

diff --git a/chrome/browser/password_manager/password_store_win.cc b/chrome/browser/password_manager/password_store_win.cc

index ff10e21f2fa609507f81d17dca4e355044384e27..cc02c6ee382cce8b5dfd14245b1238b9370b92a4 100644

--- a/chrome/browser/password_manager/password_store_win.cc

+++ b/chrome/browser/password_manager/password_store_win.cc

@@ -16,8 +16,8 @@

#include "chrome/browser/webdata/web_data_service.h"

#include "components/webdata/encryptor/ie7_password.h"

+using autofill::PasswordForm;

using content::BrowserThread;

-using content::PasswordForm;

// Handles requests to WebDataService.

class PasswordStoreWin::DBHandler : public WebDataServiceConsumer {

@@ -143,7 +143,7 @@ void PasswordStoreWin::DBHandler::OnWebDataServiceRequestDone(

i->second.callback_runner);

pending_requests_.erase(i);

- std::vector<content::PasswordForm*> matched_forms;

+ std::vector<autofill::PasswordForm*> matched_forms;

if (!result) {

// The WDS returns NULL if it is shutting down. Run callback with empty

@@ -186,7 +186,7 @@ void PasswordStoreWin::ShutdownOnUIThread() {

void PasswordStoreWin::GetIE7LoginIfNecessary(

const PasswordForm& form,

const ConsumerCallbackRunner& callback_runner,

- const std::vector<content::PasswordForm*>& matched_forms) {

+ const std::vector<autofill::PasswordForm*>& matched_forms) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));

if (matched_forms.empty() && db_handler_.get()) {

db_handler_->GetIE7Login(form, callback_runner);