Issue 23728003: Return Frame&, not Frame* from RenderView::frame()

Issue 23728003: Return Frame&, not Frame* from RenderView::frame() (Closed)

Created:
7 years, 3 months ago by caseq

Modified:
7 years, 3 months ago

Reviewers:
tkent, abarth-chromium

CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, aandrey+blink_chromium.org, blink-layers+watch_chromium.org, caseq+blink_chromium.org, aboxhall, yurys+blink_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, kenneth.christiansen, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dmazzoni, jeez, eseidel

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Return Frame&, not Frame* from RenderView::frame() R=tkent@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157106

Patch Set 1 #

Patch Set 2 : fixed broken build with !LOG_DISABLED #

Patch Set 3 : fixed PopupMenuTest build #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -104 lines)			Patch
M	Source/core/accessibility/AXObjectCache.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/accessibility/AccessibilityObject.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/accessibility/AccessibilityRenderObject.cpp	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/accessibility/AccessibilityScrollView.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/Caret.cpp	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	Source/core/page/EventHandler.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/page/Frame.cpp	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	Source/core/page/FrameView.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/FrameView.cpp	View		21 chunks	+27 lines, -31 lines	0 comments	Download
M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/platform/Scrollbar.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	Source/core/plugins/IFrameShimSupport.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderIFrame.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	Source/core/rendering/RenderLayerBacking.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderLayerCompositor.cpp	View	1	7 chunks	+14 lines, -17 lines	0 comments	Download
M	Source/core/rendering/RenderTreeAsText.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderView.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderWidget.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/PopupContainer.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/web/PopupMenuChromium.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	Source/web/WebDevToolsAgentImpl.cpp	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	Source/web/WebPluginContainerImpl.cpp	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/web/tests/PopupMenuTest.cpp	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/23728003/1

7 years, 3 months ago (2013-09-02 10:09:51 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 3 months ago (2013-09-02 10:39:35 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/23728003/5001

7 years, 3 months ago (2013-09-02 16:15:29 UTC) #5

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 3 months ago (2013-09-02 16:53:47 UTC) #6

caseq

7 years, 3 months ago (2013-09-03 06:19:23 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r157106 (presubmit successful).

Expand Messages | Collapse Messages