Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: Source/core/page/EventHandler.cpp

Issue 23728003: Return Frame&, not Frame* from RenderView::frame() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed PopupMenuTest build Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/Caret.cpp ('k') | Source/core/page/Frame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/EventHandler.cpp
diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp
index e03826eec5bf1a0a4d5d01af886bbaa55c9bd788..d29c43cb81983b1169dc70a89bb27f724178909b 100644
--- a/Source/core/page/EventHandler.cpp
+++ b/Source/core/page/EventHandler.cpp
@@ -1051,7 +1051,7 @@ Frame* EventHandler::subframeForTargetNode(Node* node)
if (!widget || !widget->isFrameView())
return 0;
- return toFrameView(widget)->frame();
+ return &toFrameView(widget)->frame();
}
static bool isSubmitImage(Node* node)
@@ -2463,7 +2463,7 @@ bool EventHandler::passGestureEventToWidget(const PlatformGestureEvent& gestureE
if (!widget->isFrameView())
return false;
- return toFrameView(widget)->frame()->eventHandler()->handleGestureEvent(gestureEvent);
+ return toFrameView(widget)->frame().eventHandler()->handleGestureEvent(gestureEvent);
}
bool EventHandler::passGestureEventToWidgetIfPossible(const PlatformGestureEvent& gestureEvent, RenderObject* renderer)
@@ -3820,7 +3820,7 @@ bool EventHandler::passWheelEventToWidget(const PlatformWheelEvent& wheelEvent,
if (!widget->isFrameView())
return false;
- return toFrameView(widget)->frame()->eventHandler()->handleWheelEvent(wheelEvent);
+ return toFrameView(widget)->frame().eventHandler()->handleWheelEvent(wheelEvent);
}
bool EventHandler::passWidgetMouseDownEventToWidget(const MouseEventWithHitTestResults& event)
« no previous file with comments | « Source/core/editing/Caret.cpp ('k') | Source/core/page/Frame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698