Source/core/rendering/RenderLayerBacking.cpp - Issue 23728003: Return Frame&, not Frame* from RenderView::frame()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayerBacking.cpp

Issue 23728003: Return Frame&, not Frame* from RenderView::frame() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fixed PopupMenuTest build Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderLayerBacking.cpp

diff --git a/Source/core/rendering/RenderLayerBacking.cpp b/Source/core/rendering/RenderLayerBacking.cpp

index 264c2f025e73e53c84464a9ce5c81a702f056e7e..3b7048b5b957623d08a89ec6c0aea2c086895e7b 100644

--- a/Source/core/rendering/RenderLayerBacking.cpp

+++ b/Source/core/rendering/RenderLayerBacking.cpp

@@ -159,9 +159,9 @@ RenderLayerBacking::RenderLayerBacking(RenderLayer* layer)

, m_backgroundLayerPaintsFixedRootBackground(false)

{

if (layer->isRootLayer()) {

- Frame* frame = toRenderView(renderer())->frameView()->frame();

- Page* page = frame ? frame->page() : 0;

- if (page && frame && page->mainFrame() == frame) {

+ Frame& frame = toRenderView(renderer())->frameView()->frame();

+ Page* page = frame.page();

+ if (page && page->mainFrame() == &frame) {

m_isMainFrameRenderViewLayer = true;

}