Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2507)

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 23728003: Return Frame&, not Frame* from RenderView::frame() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed PopupMenuTest build Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/PopupMenuChromium.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDevToolsAgentImpl.cpp
diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp
index 51ef90adbe54cd3921a0882dc8df73e0e18acacc..1d9bd96b01a1c0e130b7a57cc0dc4d2901245c6e 100644
--- a/Source/web/WebDevToolsAgentImpl.cpp
+++ b/Source/web/WebDevToolsAgentImpl.cpp
@@ -212,7 +212,7 @@ public:
m_originalZoomFactor = 0;
m_webView->setTextZoomFactor(textZoomFactor);
applySizeOverrideInternal(view, FitWindowAllowed);
- autoZoomPageToFitWidth(view->frame());
+ autoZoomPageToFitWidth(&view->frame());
m_webView->sendResizeEventAndRepaint();
}
@@ -228,9 +228,6 @@ public:
void autoZoomPageToFitWidth(Frame* frame)
{
- if (!frame)
- return;
-
frame->setTextZoomFactor(m_webView->textZoomFactor());
ensureOriginalZoomFactor(frame->view());
Document* document = frame->document();
@@ -338,7 +335,7 @@ private:
if (IntSize(overrideWidth, overrideHeight) != frameView->size())
frameView->resize(overrideWidth, overrideHeight);
- Document* doc = frameView->frame()->document();
+ Document* doc = frameView->frame().document();
doc->styleResolverChanged(RecalcStyleImmediately);
doc->updateLayout();
}
« no previous file with comments | « Source/web/PopupMenuChromium.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698