Return Frame&, not Frame* from RenderView::frame()

Source/web/tests/PopupMenuTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 389 matching lines @@
     EXPECT_EQ(2, selectedIndex());
 }
 
 TEST_F(SelectPopupMenuTest, DISABLED_SelectItemEventFire)
 {
     registerMockedURLLoad("select_event.html");
     m_webView->settings()->setJavaScriptEnabled(true);
     loadFrame(m_webView->mainFrame(), "select_event.html");
     serveRequests();
 
-    m_popupMenuClient.setFocusedNode(toWebFrameImpl(m_webView->mainFrame())->frameView()->frame()->document()->focusedElement());
+    m_popupMenuClient.setFocusedNode(toWebFrameImpl(m_webView->mainFrame())->frameView()->frame().document()->focusedElement());
 
     showPopup();
 
     int menuItemHeight = m_webView->selectPopup()->menuItemHeight();
     // menuItemHeight * 0.5 means the Y position on the item at index 0.
     IntPoint row1Point(2, menuItemHeight * 0.5);
     simulateLeftMouseDownEvent(row1Point);
     simulateLeftMouseUpEvent(row1Point);
 
     WebElement element = m_webView->mainFrame()->document().getElementById("message");
@@ skipping 24 matching lines @@
     EXPECT_STREQ("upclickchangeupclick", element.innerText().utf8().data());
 }
 
 TEST_F(SelectPopupMenuTest, FLAKY_SelectItemKeyEvent)
 {
     registerMockedURLLoad("select_event.html");
     m_webView->settings()->setJavaScriptEnabled(true);
     loadFrame(m_webView->mainFrame(), "select_event.html");
     serveRequests();
 
-    m_popupMenuClient.setFocusedNode(toWebFrameImpl(m_webView->mainFrame())->frameView()->frame()->document()->focusedElement());
+    m_popupMenuClient.setFocusedNode(toWebFrameImpl(m_webView->mainFrame())->frameView()->frame().document()->focusedElement());
 
     showPopup();
 
     // Siumulate to choose the item at index 1 with keyboard.
     simulateKeyDownEvent(VKEY_DOWN);
     simulateKeyDownEvent(VKEY_DOWN);
     simulateKeyDownEvent(VKEY_RETURN);
 
     WebElement element = m_webView->mainFrame()->document().getElementById("message");
     // We only can see change event but no other mouse related events.
     EXPECT_STREQ("change", element.innerText().utf8().data());
 }
 
 TEST_F(SelectPopupMenuTest, SelectItemRemoveSelectOnChange)
 {
     // Make sure no crash, even if select node is removed on 'change' event handler.
     registerMockedURLLoad("select_event_remove_on_change.html");
     m_webView->settings()->setJavaScriptEnabled(true);
     loadFrame(m_webView->mainFrame(), "select_event_remove_on_change.html");
     serveRequests();
 
-    m_popupMenuClient.setFocusedNode(toWebFrameImpl(m_webView->mainFrame())->frameView()->frame()->document()->focusedElement());
+    m_popupMenuClient.setFocusedNode(toWebFrameImpl(m_webView->mainFrame())->frameView()->frame().document()->focusedElement());
 
     showPopup();
 
     int menuItemHeight = m_webView->selectPopup()->menuItemHeight();
     // menuItemHeight * 1.5 means the Y position on the item at index 1.
     IntPoint row1Point(2, menuItemHeight * 1.5);
     simulateLeftMouseDownEvent(row1Point);
     simulateLeftMouseUpEvent(row1Point);
 
     WebElement element = m_webView->mainFrame()->document().getElementById("message");
     EXPECT_STREQ("change", element.innerText().utf8().data());
 }
 
 TEST_F(SelectPopupMenuTest, SelectItemRemoveSelectOnClick)
 {
     // Make sure no crash, even if select node is removed on 'click' event handler.
     registerMockedURLLoad("select_event_remove_on_click.html");
     m_webView->settings()->setJavaScriptEnabled(true);
     loadFrame(m_webView->mainFrame(), "select_event_remove_on_click.html");
     serveRequests();
 
-    m_popupMenuClient.setFocusedNode(toWebFrameImpl(m_webView->mainFrame())->frameView()->frame()->document()->focusedElement());
+    m_popupMenuClient.setFocusedNode(toWebFrameImpl(m_webView->mainFrame())->frameView()->frame().document()->focusedElement());
 
     showPopup();
 
     int menuItemHeight = m_webView->selectPopup()->menuItemHeight();
     // menuItemHeight * 1.5 means the Y position on the item at index 1.
     IntPoint row1Point(2, menuItemHeight * 1.5);
     simulateLeftMouseDownEvent(row1Point);
     simulateLeftMouseUpEvent(row1Point);
 
     WebElement element = m_webView->mainFrame()->document().getElementById("message");
     EXPECT_STREQ("click", element.innerText().utf8().data());
 }
 
 } // namespace