Source/web/PopupMenuChromium.cpp - Issue 23728003: Return Frame&, not Frame* from RenderView::frame()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupMenuChromium.cpp

Issue 23728003: Return Frame&, not Frame* from RenderView::frame() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fixed PopupMenuTest build Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/PopupMenuChromium.cpp

diff --git a/Source/web/PopupMenuChromium.cpp b/Source/web/PopupMenuChromium.cpp

index ed9ebddc30397036fda76412ddc5435ef8e7ba41..38bbeb00f2d9ea7f941912cd639ffd7556f6acd2 100644

--- a/Source/web/PopupMenuChromium.cpp

+++ b/Source/web/PopupMenuChromium.cpp

@@ -71,7 +71,7 @@ void PopupMenuChromium::show(const FloatQuad& controlPosition, const IntSize& co

{

if (!m_popup) {

PopupContainerSettings popupSettings = dropDownSettings;

- popupSettings.deviceSupportsTouch = m_frameView->frame()->page()->settings().deviceSupportsTouch();

+ popupSettings.deviceSupportsTouch = m_frameView->frame().page()->settings().deviceSupportsTouch();

m_popup = PopupContainer::create(client(), PopupContainer::Select, popupSettings);

}

m_popup->showInRect(controlPosition, controlSize, m_frameView.get(), index);

« no previous file with comments | « Source/web/PopupContainer.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »