Issue 23717008: Remove useless null checks from Node::document() call sites

Issue 23717008: Remove useless null checks from Node::document() call sites (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, abarth-chromium

CC:
blink-reviews, aboxhall, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), Stephen Chennney, Hajime Morrita

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove useless null checks from Node::document() call sites Remove useless null checks from Node::document() call sites now that all nodes have an associated Document at all times. This is a preparation patch to later have Node::document() return a reference. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156986

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -97 lines)			Patch
M	Source/core/accessibility/AccessibilityObject.cpp	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/core/css/resolver/ElementResolveContext.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/ContainerNode.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/EventPathWalker.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/dom/Node.h	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	Source/core/dom/Node.cpp	View	6 chunks	+19 lines, -26 lines	0 comments	Download
M	Source/core/dom/NodeIterator.cpp	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	Source/core/dom/Position.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/FrameSelection.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/VisibleUnits.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/markup.cpp	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	Source/core/html/HTMLElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/LabelableElement.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/page/Chrome.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/page/EventHandler.cpp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/page/FocusController.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderMenuList.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderTreeAsText.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGElementRareData.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XMLSerializer.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23717008/1

7 years, 3 months ago (2013-08-30 11:41:44 UTC) #3

Message was sent while issue was closed.

Change committed as 156986

Expand Messages | Collapse Messages