Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 23717008: Remove useless null checks from Node::document() call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderMenuList.cpp ('k') | Source/core/rendering/RenderTreeAsText.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
592 Node* nonPseudoNode() const { return isPseudoElement() ? 0 : node(); } 592 Node* nonPseudoNode() const { return isPseudoElement() ? 0 : node(); }
593 593
594 // FIXME: Why does RenderWidget need this? 594 // FIXME: Why does RenderWidget need this?
595 void clearNode() { m_node = 0; } 595 void clearNode() { m_node = 0; }
596 596
597 // Returns the styled node that caused the generation of this renderer. 597 // Returns the styled node that caused the generation of this renderer.
598 // This is the same as node() except for renderers of :before and :after 598 // This is the same as node() except for renderers of :before and :after
599 // pseudo elements for which their parent node is returned. 599 // pseudo elements for which their parent node is returned.
600 Node* generatingNode() const { return isPseudoElement() ? node()->parentOrSh adowHostNode() : node(); } 600 Node* generatingNode() const { return isPseudoElement() ? node()->parentOrSh adowHostNode() : node(); }
601 601
602 // FIXME: This should return a reference.
602 Document* document() const { return m_node->document(); } 603 Document* document() const { return m_node->document(); }
603 Frame* frame() const { return document()->frame(); } 604 Frame* frame() const { return document()->frame(); }
604 605
605 bool hasOutlineAnnotation() const; 606 bool hasOutlineAnnotation() const;
606 bool hasOutline() const { return style()->hasOutline() || hasOutlineAnnotati on(); } 607 bool hasOutline() const { return style()->hasOutline() || hasOutlineAnnotati on(); }
607 608
608 // Returns the object containing this one. Can be different from parent for positioned elements. 609 // Returns the object containing this one. Can be different from parent for positioned elements.
609 // If repaintContainer and repaintContainerSkipped are not null, on return * repaintContainerSkipped 610 // If repaintContainer and repaintContainerSkipped are not null, on return * repaintContainerSkipped
610 // is true if the renderer returned is an ancestor of repaintContainer. 611 // is true if the renderer returned is an ancestor of repaintContainer.
611 RenderObject* container(const RenderLayerModelObject* repaintContainer = 0, bool* repaintContainerSkipped = 0) const; 612 RenderObject* container(const RenderLayerModelObject* repaintContainer = 0, bool* repaintContainerSkipped = 0) const;
(...skipping 778 matching lines...) Expand 10 before | Expand all | Expand 10 after
1390 // Outside the WebCore namespace for ease of invocation from gdb. 1391 // Outside the WebCore namespace for ease of invocation from gdb.
1391 void showTree(const WebCore::RenderObject*); 1392 void showTree(const WebCore::RenderObject*);
1392 void showLineTree(const WebCore::RenderObject*); 1393 void showLineTree(const WebCore::RenderObject*);
1393 void showRenderTree(const WebCore::RenderObject* object1); 1394 void showRenderTree(const WebCore::RenderObject* object1);
1394 // We don't make object2 an optional parameter so that showRenderTree 1395 // We don't make object2 an optional parameter so that showRenderTree
1395 // can be called from gdb easily. 1396 // can be called from gdb easily.
1396 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2); 1397 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);
1397 #endif 1398 #endif
1398 1399
1399 #endif // RenderObject_h 1400 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderMenuList.cpp ('k') | Source/core/rendering/RenderTreeAsText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698