Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: Source/core/rendering/RenderMenuList.cpp

Issue 23717008: Remove useless null checks from Node::document() call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/FocusController.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of the select element renderer in WebCore. 2 * This file is part of the select element renderer in WebCore.
3 * 3 *
4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
5 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
6 * 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 6 * 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 { 341 {
342 if (m_popup) 342 if (m_popup)
343 m_popup->hide(); 343 m_popup->hide();
344 } 344 }
345 345
346 void RenderMenuList::valueChanged(unsigned listIndex, bool fireOnChange) 346 void RenderMenuList::valueChanged(unsigned listIndex, bool fireOnChange)
347 { 347 {
348 // Check to ensure a page navigation has not occurred while 348 // Check to ensure a page navigation has not occurred while
349 // the popup was up. 349 // the popup was up.
350 Document* doc = toElement(node())->document(); 350 Document* doc = toElement(node())->document();
351 if (!doc || doc != doc->frame()->document()) 351 if (doc != doc->frame()->document())
352 return; 352 return;
353 353
354 HTMLSelectElement* select = selectElement(); 354 HTMLSelectElement* select = selectElement();
355 select->optionSelectedByUser(select->listToOptionIndex(listIndex), fireOnCha nge); 355 select->optionSelectedByUser(select->listToOptionIndex(listIndex), fireOnCha nge);
356 } 356 }
357 357
358 void RenderMenuList::listBoxSelectItem(int listIndex, bool allowMultiplySelectio ns, bool shift, bool fireOnChangeNow) 358 void RenderMenuList::listBoxSelectItem(int listIndex, bool allowMultiplySelectio ns, bool shift, bool fireOnChangeNow)
359 { 359 {
360 selectElement()->listBoxSelectItem(listIndex, allowMultiplySelections, shift , fireOnChangeNow); 360 selectElement()->listBoxSelectItem(listIndex, allowMultiplySelections, shift , fireOnChangeNow);
361 } 361 }
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 { 613 {
614 setTextFromOption(selectElement()->listToOptionIndex(listIndex)); 614 setTextFromOption(selectElement()->listToOptionIndex(listIndex));
615 } 615 }
616 616
617 FontSelector* RenderMenuList::fontSelector() const 617 FontSelector* RenderMenuList::fontSelector() const
618 { 618 {
619 return document()->styleResolver()->fontSelector(); 619 return document()->styleResolver()->fontSelector();
620 } 620 }
621 621
622 } 622 }
OLDNEW
« no previous file with comments | « Source/core/page/FocusController.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698