Source/core/rendering/RenderMenuList.cpp - Issue 23717008: Remove useless null checks from Node::document() call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMenuList.cpp

Issue 23717008: Remove useless null checks from Node::document() call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderMenuList.cpp

diff --git a/Source/core/rendering/RenderMenuList.cpp b/Source/core/rendering/RenderMenuList.cpp

index f614d032aeb2959a8b4ff72756794c8ef1a67399..d7710c39dcd35685c43ca140e8786e1a8de2edf0 100644

--- a/Source/core/rendering/RenderMenuList.cpp

+++ b/Source/core/rendering/RenderMenuList.cpp

@@ -348,7 +348,7 @@ void RenderMenuList::valueChanged(unsigned listIndex, bool fireOnChange)

// Check to ensure a page navigation has not occurred while

// the popup was up.

Document* doc = toElement(node())->document();

- if (!doc || doc != doc->frame()->document())

+ if (doc != doc->frame()->document())

return;

HTMLSelectElement* select = selectElement();

« no previous file with comments | « Source/core/page/FocusController.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »