Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Side by Side Diff: Source/core/xml/XMLSerializer.cpp

Issue 23717008: Remove useless null checks from Node::document() call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGElementRareData.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2006 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2006 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig (sam@webkit.org) 3 * Copyright (C) 2006 Samuel Weinig (sam@webkit.org)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Lesser General Public 6 * modify it under the terms of the GNU Lesser General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 15 matching lines...) Expand all
26 #include "core/editing/markup.h" 26 #include "core/editing/markup.h"
27 #include "wtf/text/WTFString.h" 27 #include "wtf/text/WTFString.h"
28 28
29 namespace WebCore { 29 namespace WebCore {
30 30
31 String XMLSerializer::serializeToString(Node* node, ExceptionState& es) 31 String XMLSerializer::serializeToString(Node* node, ExceptionState& es)
32 { 32 {
33 if (!node) 33 if (!node)
34 return String(); 34 return String();
35 35
36 if (!node->document()) {
37 // Due to the fact that DocumentType nodes are created by the DOMImpleme ntation
38 // and not the Document, it is possible for it to not have a Document as sociated
39 // with it. It should be the only type of node where this is possible.
40 ASSERT(node->nodeType() == Node::DOCUMENT_TYPE_NODE);
41
42 es.throwDOMException(InvalidAccessError);
43 return String();
44 }
45
46 return createMarkup(node); 36 return createMarkup(node);
47 } 37 }
48 38
49 } // namespace WebCore 39 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/svg/SVGElementRareData.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698