Source/core/editing/FrameSelection.cpp - Issue 23717008: Remove useless null checks from Node::document() call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 23717008: Remove useless null checks from Node::document() call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index ea5fb2b1231d2d3612b5fefeca0d43a81650db2f..974ad4e94da696efb7f4a1e43a639b90dbf2aed9 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -242,7 +242,7 @@ void FrameSelection::setSelection(const VisibleSelection& newSelection, SetSelec

// if document->frame() == m_frame we can get into an infinite loop

if (s.base().anchorNode()) {

Document* document = s.base().anchorNode()->document();

- if (document && document->frame() && document->frame() != m_frame && document != m_frame->document()) {

+ if (document->frame() && document->frame() != m_frame && document != m_frame->document()) {

RefPtr<Frame> guard = document->frame();

document->frame()->selection()->setSelection(s, options, align, granularity);

// It's possible that during the above set selection, this FrameSelection has been modified by

« no previous file with comments | « Source/core/dom/Position.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »